Skip to content

gh-103438: Don't define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64 #103439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreas-schwab wants to merge 1 commit into from
Closed

gh-103438: Don't define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64 #103439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-103438: Don't define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64 
This was a workaround for a bug in libffi that has been fixed.
  • Loading branch information
@andreas-schwab
andreas-schwab committed Nov 14, 2023
commit 608ee2dc89e59ea1c287544bc0cb8d9d681232a9
3 changes: 1 addition & 2 deletions Modules/_ctypes/callproc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,8 +1139,7 @@ GetComError(HRESULT errcode, GUID *riid, IUnknown *pIunk)
}
#endif

#if (defined(__x86_64__) && (defined(__MINGW64__) || defined(__CYGWIN__))) || \
defined(__aarch64__) || defined(__riscv)
#if (defined(__x86_64__) && (defined(__MINGW64__) || defined(__CYGWIN__)))
#define CTYPES_PASS_BY_REF_HACK
#define POW2(x) (((x & ~(x - 1)) == x) ? x : 0)
#define IS_PASS_BY_REF(x) (x > 8 || !POW2(x))
Expand Down