Skip to content

gh-102837: few coverage nitpicks for the math module #102523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 20 commits into from
Sep 3, 2023
Merged

gh-102837: few coverage nitpicks for the math module #102523

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
68b2e42
gh-102837: few coverage nitpicks for the math module
skirpichev Feb 23, 2023
dc85378
Merge branch 'main' into math-cov
skirpichev Apr 3, 2023
86aee3c
Merge branch 'main' into math-cov
skirpichev Apr 8, 2023
9c32ae0
Simplify math_1, like other functions
skirpichev Apr 7, 2023
b8cf8ac
Merge branch 'main' into math-cov
skirpichev Apr 17, 2023
b395cfb
Merge branch 'main' into math-cov
skirpichev Apr 22, 2023
c3bd1cd
Merge branch 'main' into math-cov
skirpichev Apr 29, 2023
dc8ac10
Merge branch 'main' into math-cov
skirpichev Jun 11, 2023
acb851d
Merge branch 'main' into math-cov
skirpichev Jul 26, 2023
a6c769e
Merge branch 'main' into math-cov
skirpichev Aug 2, 2023
d45ea20
Merge branch 'math-cov' of github.com:skirpichev/cpython into math-cov
skirpichev Sep 2, 2023
59a5422
Merge branch 'main' into math-cov
skirpichev Sep 2, 2023
a0c619b
Add asserts
skirpichev Sep 2, 2023
b991b7c
Amend 9c32ae022f (comment restored)
skirpichev Sep 2, 2023
192a279
Merge branch 'main' into math-cov
skirpichev Sep 2, 2023
828ba75
Revert back math_floor(), add tests to cover L1239 (same for ceil())
skirpichev Sep 2, 2023
6498162
Tests for bad __floor__/__ceil__ descriptors (cover L1165, L1236)
skirpichev Sep 2, 2023
8fcca16
+1
skirpichev Sep 3, 2023
796bdca
Revert "Simplify math_1, like other functions"
skirpichev Sep 3, 2023
c7d1764
Merge branch 'main' into math-cov
skirpichev Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
+1
  • Loading branch information
@skirpichev
skirpichev committed Sep 3, 2023
commit 8fcca165e0c25949618fdbe148284066ba93cbca
14 changes: 6 additions & 8 deletions Lib/test/test_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ def __init__(self, value):
def __index__(self):
return self.value

class BadDescr:
def __get__(self, obj, objtype=None):
raise ValueError

class MathTests(unittest.TestCase):

def ftest(self, name, got, expected, ulp_tol=5, abs_tol=0.0):
Expand Down Expand Up @@ -419,10 +423,7 @@ def __ceil__(self):
class TestNoCeil:
pass
class TestBadCeil:
class BadCeil:
def __get__(self, obj, objtype=None):
raise ValueError
__ceil__ = BadCeil()
__ceil__ = BadDescr()
self.assertEqual(math.ceil(TestCeil()), 42)
self.assertEqual(math.ceil(FloatCeil()), 42)
self.assertEqual(math.ceil(FloatLike(42.5)), 43)
Expand Down Expand Up @@ -578,10 +579,7 @@ def __floor__(self):
class TestNoFloor:
pass
class TestBadFloor:
class BadFloor:
def __get__(self, obj, objtype=None):
raise ValueError
__floor__ = BadFloor()
__floor__ = BadDescr()
self.assertEqual(math.floor(TestFloor()), 42)
self.assertEqual(math.floor(FloatFloor()), 42)
self.assertEqual(math.floor(FloatLike(41.9)), 41)
Expand Down