Skip to content

gh-99108: Refactor _sha256 & _sha512 into _sha2. #101924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 13 commits into from
Feb 16, 2023
Merged

gh-99108: Refactor _sha256 & _sha512 into _sha2. #101924

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fea4cdf
gh-99108: Refactor _sha256 & _sha512 into _sha2.
gpshead Feb 15, 2023
30c9955
update stdlib module names list.
gpshead Feb 15, 2023
4c6a4fb
remove the added subTest calls (no real value).
gpshead Feb 15, 2023
cf6b330
cleanup per review comments.
gpshead Feb 15, 2023
610cf36
rename the _sha2 types and simplify module init to use PyModule_AddType.
gpshead Feb 15, 2023
40fd92a
Explicitly test that direct type constructors fail.
gpshead Feb 15, 2023
d379e28
missing param
gpshead Feb 15, 2023
fb6454d
remove the unconstructable test (not a valid constraint for everything)
gpshead Feb 15, 2023
32b8f91
Merge branch 'main' into build/sha2
gpshead Feb 16, 2023
b7259c3
fix compiler warnings.
gpshead Feb 16, 2023
cbd04b0
Merge branch 'build/sha2' of github.com:gpshead/cpython into build/sha2
gpshead Feb 16, 2023
bc52384
Merge remote-tracking branch 'upstream/main' into build/sha2
gpshead Feb 16, 2023
b67918d
rename LIBHACL_ make vars to LIBHACL_SHA2_
gpshead Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove the added subTest calls (no real value).
  • Loading branch information
@gpshead
gpshead committed Feb 15, 2023
commit 4c6a4fb5cb83ba0044b3812b4fa0e599c254fa24
44 changes: 21 additions & 23 deletions Lib/test/test_hashlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,20 +369,19 @@ def check(self, name, data, hexdigest, shake=False, **kwargs):
# 2 is for hashlib.name(...) and hashlib.new(name, ...)
self.assertGreaterEqual(len(constructors), 2)
for hash_object_constructor in constructors:
with self.subTest(implementation=hash_object_constructor):
m = hash_object_constructor(data, **kwargs)
computed = m.hexdigest() if not shake else m.hexdigest(length)
self.assertEqual(
computed, hexdigest,
"Hash algorithm %s constructed using %s returned hexdigest"
" %r for %d byte input data that should have hashed to %r."
% (name, hash_object_constructor,
computed, len(data), hexdigest))
computed = m.digest() if not shake else m.digest(length)
digest = bytes.fromhex(hexdigest)
self.assertEqual(computed, digest)
if not shake:
self.assertEqual(len(digest), m.digest_size)
m = hash_object_constructor(data, **kwargs)
computed = m.hexdigest() if not shake else m.hexdigest(length)
self.assertEqual(
computed, hexdigest,
"Hash algorithm %s constructed using %s returned hexdigest"
" %r for %d byte input data that should have hashed to %r."
% (name, hash_object_constructor,
computed, len(data), hexdigest))
computed = m.digest() if not shake else m.digest(length)
digest = bytes.fromhex(hexdigest)
self.assertEqual(computed, digest)
if not shake:
self.assertEqual(len(digest), m.digest_size)

if not shake and kwargs.get("key") is None:
# skip shake and blake2 extended parameter tests
Expand All @@ -403,15 +402,14 @@ def check_file_digest(self, name, data, hexdigest):

try:
for digest in digests:
with self.subTest(msg="check_file_digest", implementation=digest):
buf = io.BytesIO(data)
buf.seek(0)
self.assertEqual(
hashlib.file_digest(buf, digest).hexdigest(), hexdigest
)
with open(os_helper.TESTFN, "rb") as f:
digestobj = hashlib.file_digest(f, digest)
self.assertEqual(digestobj.hexdigest(), hexdigest)
buf = io.BytesIO(data)
buf.seek(0)
self.assertEqual(
hashlib.file_digest(buf, digest).hexdigest(), hexdigest
)
with open(os_helper.TESTFN, "rb") as f:
digestobj = hashlib.file_digest(f, digest)
self.assertEqual(digestobj.hexdigest(), hexdigest)
finally:
os.unlink(os_helper.TESTFN)

Expand Down