Skip to content

Support re as an alternative to regex - #76

Merged
ppannuto merged 2 commits into
ppannuto:mainfrom
rkhwaja:allow-re-module
Feb 11, 2021
Merged

Support re as an alternative to regex#76
ppannuto merged 2 commits into
ppannuto:mainfrom
rkhwaja:allow-re-module

Conversation

@rkhwaja

@rkhwaja rkhwaja commented Feb 10, 2021

Copy link
Copy Markdown
Contributor

Switch regex to an optional requirement in setup.py
Fallback to re if it doesn't import

@rkhwaja

rkhwaja commented Feb 10, 2021

Copy link
Copy Markdown
Contributor Author

Fixes #76

@coveralls

coveralls commented Feb 10, 2021 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.8%) to 80.976% when pulling e4a6f18 on rkhwaja:allow-re-module into b7f0d87 on ppannuto:main.

@coveralls

coveralls commented Feb 10, 2021

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.8%) to 80.976% when pulling bd647e4 on rkhwaja:allow-re-module into b7f0d87 on ppannuto:main.

ppannuto
ppannuto reviewed Feb 10, 2021
View reviewed changes
Comment thread setup.py Outdated
@rkhwaja @ppannuto
Update setup.py
e4a6f18 
Co-authored-by: Pat Pannuto <pat.pannuto@gmail.com>
@ppannuto
ppannuto merged commit e720bf6 into ppannuto:main Feb 11, 2021
@rkhwaja rkhwaja mentioned this pull request Feb 15, 2021
Closed
ppannuto added a commit that referenced this pull request Jun 10, 2021
@ppannuto
v2.1
56a10b1 
Some small fixes to the install process. Kicking out as a point
release in case the regex/re change has any unexpected side-effects.

 - #76: regex now optional, fallback to re (thanks @rkhwaja!)
 - #80: Fix UnicodeDecodeError on Windows pip (thanks @Gateswong!)
@brocksam brocksam mentioned this pull request Jun 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppannuto ppannuto ppannuto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rkhwaja @coveralls @ppannuto