This repository was archived by the owner on Oct 2, 2018. It is now read-only.
[COOK-3719] Allow more custom configuration#56
Closed
garrypolley wants to merge 2 commits into
Closed
Conversation
Member
There was a problem hiding this comment.
Typo, also don't use the method_missing form of attributes.
Contributor
Author
|
This also fixes #52 : |
Contributor
Author
|
@coderanger Thanks for the comments, I've updated the code with those comments in mind. Any more suggestions before this would get merged? |
Member
|
Looks fine, an probably better than #52 for now. 👍 for merging. |
|
looks fine to me. |
|
👍 Looks good |
Contributor
|
Merged in 5e02477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tickets.opscode.com/browse/COOK-3719
This will allow an easier
altinstallof Python. Allows for using the built-inaltinstallcommand option to make. As well as, allows for finer grained control of which pip and virtualenv to use.