Skip to content

Fix: multiple HTML rendering and crash bugs in PDF exports#68

Merged
stonebuzz merged 2 commits into
10.0/bugfixesfrom
support_43955
May 27, 2026
Merged

Fix: multiple HTML rendering and crash bugs in PDF exports#68
stonebuzz merged 2 commits into
10.0/bugfixesfrom
support_43955

Conversation

@Rom1-B
Copy link
Copy Markdown

@Rom1-B Rom1-B commented May 19, 2026

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !43955

  • TypeError crash when exporting Problems or Changes with linked items that lack serial/otherserial columns (e.g. Software, User): fixed by using null-coalescing fallback before Toolbox::stripTags().

  • Description rendered as a single block in Problem and Change PDFs: Toolbox::stripTags() was stripping HTML structure before displayText(), which expects HTML. The strip call is removed.

  • Change analysis and plan fields showing raw HTML: fields were embedded in the label argument via sprintf() instead of being passed as the content argument to displayText(). Fixed argument placement; also removed ineffective setColumnsSize(10, 90) calls before displayText() (which forces 100% internally).

  • Ticket approval comments showing HTML fragments: comment fields were stored with HTML entities not decoded before PDF rendering. Fixed using html_entity_decode().

TODO: same PR on main

@Rom1-B Rom1-B marked this pull request as draft May 19, 2026 09:20
@Rom1-B Rom1-B marked this pull request as ready for review May 25, 2026 10:29
@Rom1-B Rom1-B requested a review from stonebuzz May 26, 2026 14:34
@stonebuzz stonebuzz merged commit 33dc2d2 into 10.0/bugfixes May 27, 2026
3 checks passed
@stonebuzz stonebuzz deleted the support_43955 branch May 27, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants