More precise microtime() return type#4347
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Feb 5, 2026
Merged
Conversation
staabm
reviewed
Sep 21, 2025
|
|
||
| public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type | ||
| { | ||
| $stringType = new IntersectionType([new StringType(), new AccessoryNonFalsyStringType()]); |
Contributor
There was a problem hiding this comment.
not sure it will be helpful, but I think we could in addition make it a AccessoryLowercaseStringType
Contributor
There was a problem hiding this comment.
Why? It is neither LC or UC, thus it should be accepted also by uppercase-string type.
Contributor
There was a problem hiding this comment.
Why? It is neither LC or UC, thus it should be accepted also by uppercase-string type.
You can be both LC and UC.
For instance 42 is both.
So we should add both accessory AccessoryLowercaseStringType and AccessoryUppercaseStringType
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return value of
microtime(false)is never falsy.