Removed the warning when installing extensions for PHP 7#880
Merged
Conversation
3 similar comments
Member
|
LGTM the warning that the version of extensions should match the version of php is applied to all php versions, not only 7.x. I think simpily removing it or changing it to a notice for all versions is ok. |
Contributor
Author
|
@jhdxr I would just remove it. If the extension is successfully installed, there's nothing to warn/notify above. If it fails, there may be a thousand reasons to that besides version incompatibility. Without the actual logic which detects compatibility, this message doesn't add any value. |
Member
|
looks good, I think most of the users are now installing extensions for php7 not for php5. so I think this is good to be merged. Or it will be too annoying if there are too many messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While PHP 5.6 only receives security updates and PHP 7 overall now represents over 50% of installations, the warning in the question seems no more relevant.