Fix match() function for PHP56WithOpenSSL11Patch#1066
Merged
morozov merged 1 commit intoDec 7, 2019
Merged
Conversation
Contributor
Author
|
My build commands are $ phpbrew --debug install --jobs "$(nproc)" 5.6.40 +default +dbs +dba +apxs2 +bz2="$(brew --prefix bzip2)" +zlib="$(brew --prefix zlib)" +curl="$(brew --prefix curl)"
$ phpbrew ext install gettext -- --with-gettext="$(brew --prefix gettext)" && phpbrew ext install iconv -- --with-iconv="$(brew --prefix libiconv)" && phpbrew ext install ftp -- --with-openssl-dir="$(brew --prefix openssl@1.1)" && phpbrew ext install exif && phpbrew ext install soap && phpbrew ext install gd -- --with-gd=shared --with-zlib-dir="$(brew --prefix zlib)" && phpbrew ext install opcache && phpbrew ext install xdebug 2.5.5Everything works, without any problems. |
Contributor
Author
|
Okay, I also tested this PR to build |
morozov
suggested changes
Dec 5, 2019
morozov
suggested changes
Dec 6, 2019
morozov
approved these changes
Dec 7, 2019
Contributor
|
Looks good. Please squash all the changes in one commit. |
Contributor
Author
|
Let me figure how to use squash, I never use it. |
Contributor
Author
|
Okay, I just squashed 3 commits to 1. Done. |
Contributor
|
Thank you, @markwu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed match() function for PHP56WithOpenSSL11Patch.php.
Reference: #1041