Skip to content

Added sodium as variant.#1064

Merged
morozov merged 1 commit into
phpbrew:masterfrom
jasny:sodium-variant
Dec 19, 2019
Merged

Added sodium as variant.#1064
morozov merged 1 commit into
phpbrew:masterfrom
jasny:sodium-variant

Conversation

@jasny

@jasny jasny commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

Sodium is part of the PHP core since 7.2.
See https://www.php.net/manual/en/sodium.installation.php

Added sodium to the default virtual variant.

@coveralls

coveralls commented Dec 3, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 40.324% when pulling 4bc90a6 on jasny:sodium-variant into 517cdfe on phpbrew:master.

@morozov morozov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasny thank you for the patch. Please see the comments.

Comment thread src/PhpBrew/VariantBuilder.php Outdated
Comment thread src/PhpBrew/VariantBuilder.php Outdated
Comment thread src/PhpBrew/VariantBuilder.php Outdated
Comment thread src/PhpBrew/VariantBuilder.php Outdated
Comment thread src/PhpBrew/VariantBuilder.php Outdated
Comment thread src/PhpBrew/VariantBuilder.php Outdated
Comment thread src/PhpBrew/VariantBuilder.php Outdated
Comment thread src/PhpBrew/VariantBuilder.php
Comment thread src/PhpBrew/VariantBuilder.php Outdated
Comment thread src/PhpBrew/VariantBuilder.php Outdated
Sodium is part of the PHP core since 7.2.
See https://www.php.net/manual/en/sodium.installation.php

Added `sodium` to the `default` virtual variant.
For PHP 7.1 and lower, a message is displayed that sodium needs
  to be installed as extension.
@morozov morozov merged commit d77ef46 into phpbrew:master Dec 19, 2019
@morozov

morozov commented Dec 19, 2019

Copy link
Copy Markdown
Contributor

Thank you @jasny. If you know which dependencies the sodium variant has on OS'es other than Ubuntu, please update the wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants