Skip to content

Improved Fish-shell completion#1051

Merged
morozov merged 1 commit into
phpbrew:masterfrom
morozov:fish-completion
Nov 12, 2019
Merged

Improved Fish-shell completion#1051
morozov merged 1 commit into
phpbrew:masterfrom
morozov:fish-completion

Conversation

@morozov

@morozov morozov commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

Major changes:

  1. Added completion for all commands, options and arguments.
  2. Some descriptions were updated.
  3. Argument suggestions are now sourced from the meta command, not from ad-hoc shell functions.
  4. The app --list option has been removed since it duplicates the app list command.

Major changes:

1. Added completion for all commands, options and arguments.
2. Some descriptions were updated.
3. Argument suggestions are now sourced from the `meta` command, not from ad-hoc shell functions.
4. The `app --list` option has been removed since it duplicates the `app list` command.
@morozov morozov requested a review from jhdxr November 4, 2019 19:53
{
$opts->add('l|list', 'Show app list.');
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize that this is a breaking change but I'd rather document it in the release notes than implement the handler of this option that would emit a deprecation message.

@coveralls

coveralls commented Nov 4, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 40.95% when pulling ea57f13 on morozov:fish-completion into 755aaf6 on phpbrew:master.

@morozov morozov merged commit 06097bd into phpbrew:master Nov 12, 2019
@morozov morozov deleted the fish-completion branch November 12, 2019 15:43
@morozov morozov added this to the Release 1.24 milestone Nov 27, 2019
@morozov morozov self-assigned this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants