Skip to content

Fixed the switch subcommand exit status on Fish#1043

Merged
morozov merged 1 commit into
phpbrew:masterfrom
morozov:fish-switch-exit-status
Oct 30, 2019
Merged

Fixed the switch subcommand exit status on Fish#1043
morozov merged 1 commit into
phpbrew:masterfrom
morozov:fish-switch-exit-status

Conversation

@morozov

@morozov morozov commented Oct 2, 2019

Copy link
Copy Markdown
Contributor

When switching PHP versions using Fish, phpbrew switch exits with a non-zero code even on success:

$ phpbrew list
  php-7.4.0RC2
* php-7.3.10

$ phpbrew switch 7.4.0RC2

$ echo $status
1

$ phpbrew list
* php-7.4.0RC2   
  php-7.3.10     

$ php -v
PHP 7.4.0RC2 (cli) (built: Sep 21 2019 15:26:11) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.0RC2, Copyright (c), by Zend Technologies
    with Xdebug v3.0.0-dev, Copyright (c) 2002-2019, by Derick Rethans

@coveralls

coveralls commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 41.248% when pulling 8e84aa8 on morozov:fish-switch-exit-status into bceaee1 on phpbrew:master.

@morozov morozov mentioned this pull request Oct 29, 2019
Closed
@morozov

morozov commented Oct 30, 2019

Copy link
Copy Markdown
Contributor Author

Merging my own PR without a review:

  1. There has been a month without feedback.
  2. None of the maintainers seem to use Fish.
  3. I've been using this patch for a month myself and haven't experienced any issues.

@morozov morozov merged commit 9f505bd into phpbrew:master Oct 30, 2019
@morozov morozov deleted the fish-switch-exit-status branch October 30, 2019 03:14
@morozov morozov self-assigned this Oct 30, 2019
@morozov morozov added this to the Release 1.24 milestone Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@morozov morozov

Labels

Bug Fish

Projects

None yet

Milestone

Release 1.24.0

Development

Successfully merging this pull request may close these issues.

2 participants

@morozov @coveralls