Skip to content

Fixed handing of .phpbrewrc in Fish#1030

Merged
morozov merged 1 commit into
phpbrew:masterfrom
morozov:fish-phpbrewrc
Jul 13, 2019
Merged

Fixed handing of .phpbrewrc in Fish#1030
morozov merged 1 commit into
phpbrew:masterfrom
morozov:fish-phpbrewrc

Conversation

@morozov

@morozov morozov commented Jun 30, 2019

Copy link
Copy Markdown
Contributor
  1. Implemented the same logic of handling .phpbrewrc files in Fish as currently implemented in Bash and ZSH.
  2. Fixed handling filesystem boundaries in Bash (the filesystem check should have been done against $curr_dir, not the current directory in the shell).
  3. Fixed a syntax error in phpbrew.fish.

@morozov

morozov commented Jun 30, 2019

Copy link
Copy Markdown
Contributor Author

The test failure will be fixed by #1029.

@morozov morozov requested review from c9s and jhdxr June 30, 2019 07:55
Additionally, fixed handling filesystem boundaries in Bash
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 40.274% when pulling ad01a5c on morozov:fish-phpbrewrc into 186ee90 on phpbrew:master.

@morozov

morozov commented Jul 13, 2019

Copy link
Copy Markdown
Contributor Author

Anyone can review/approve this?

@morozov morozov merged commit 5392e7d into phpbrew:master Jul 13, 2019
@morozov morozov deleted the fish-phpbrewrc branch July 13, 2019 11:14
@morozov morozov self-assigned this Nov 1, 2019
@morozov morozov added this to the Release 1.24 milestone Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants