test: Put the error tests from the integration tests into cmake. - #857
Merged
Conversation
eyal0
force-pushed
the
ctest_failing_examples
branch
from
March 23, 2026 20:14
18a317f to
37120b2
Compare
Collaborator
eyal0
force-pushed
the
ctest_failing_examples
branch
from
March 23, 2026 23:40
00e8ace to
37120b2
Compare
We don't need `integration_tests.py` anymore. We can generate the correct results directly into the expected directory and count on `git diff` to show us the diffs as needed. This will also run faster.
eyal0
force-pushed
the
ctest_failing_examples
branch
from
March 24, 2026 02:25
37120b2 to
9e97787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need
integration_tests.pyanymore. We can generate the correct results directly into the expected directory and count ongit diffto show us the diffs as needed. This will also run faster.