test: Remove SKIP_GERBERIMPORTER_TESTS_PNG and use command line flag --write-pngs. - #801
Merged
Merged
Conversation
eyal0
force-pushed
the
no_skip_gerberimporter_tests_png
branch
from
March 8, 2026 00:19
7cb0c45 to
8c58088
Compare
Collaborator
eyal0
force-pushed
the
no_skip_gerberimporter_tests_png
branch
2 times, most recently
from
March 8, 2026 14:53
17455ad to
792dea7
Compare
…--write-pngs. The default is to not write pngs. This makes the unit testing faster.
eyal0
force-pushed
the
no_skip_gerberimporter_tests_png
branch
from
March 8, 2026 20:37
792dea7 to
1537ddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default is to not write pngs. This makes the unit testing faster.