fix: Have invert-gerbers also properly mask the outline. - #750
Merged
Conversation
Contributor
Author
|
I hope that at least one of the tests will fail so that I can update an integration test and have coverage and a view of this change. Otherwise, I will need to add an integration test for this. |
Contributor
Author
|
It seems that there was one failure, which is good. After this passes all tests, it should be ready to go. |
eyal0
changed the title
Collaborator
The cutter was already generating inverted gerbers but because we weren't correctly honoring the bounding box, it was making an extra cut around the outside. This fix removes that cut. This is useful for using pcb2gcode to cut out a template for placing a cut PCB into the template, for flipping it to do a double-sided board. This fixes pcb2gcode#745.
eyal0
enabled auto-merge
January 15, 2026 21:13
timaydin
pushed a commit
to timaydin/pcb2gcode
that referenced
this pull request
Jan 27, 2026
fix: Have invert-gerbers also properly mask the outline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cutter was already generating inverted gerbers but because we weren't correctly honors the bounding box, it was making an extra cut around the outside. This fix removes that cut.
This is useful for using pcb2gcode to cut out a template for placing a cut PCB into the template, for flipping it to do a double-sided board.
This fixes #745.