Skip to content

onboard: default local tools profile to coding#34958

Closed
cgdusek wants to merge 1 commit intoopenclaw:mainfrom
cgdusek:codex/onboard-default-tools-profile-coding-clean
Closed

onboard: default local tools profile to coding#34958
cgdusek wants to merge 1 commit intoopenclaw:mainfrom
cgdusek:codex/onboard-default-tools-profile-coding-clean

Conversation

@cgdusek
Copy link
Contributor

@cgdusek cgdusek commented Mar 4, 2026

Summary

Consolidated regression fix for local onboarding tool profile defaults:

  • Switch local onboarding default from tools.profile: "messaging" to tools.profile: "coding"
  • Update onboarding tests to assert the new default
  • Update docs that previously stated local onboarding defaults to messaging
  • Keep local onboarding behavior bounded (not full) while restoring expected local coding workflow tools (read/write/edit/exec)

Related

Validation

  • pnpm exec vitest run src/commands/onboard-config.test.ts src/commands/onboard-non-interactive.gateway.test.ts
  • pnpm check
  • pnpm build

Exit plan

happy to move commits to #34861 and close this.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 4, 2026

Greptile Summary

This PR consolidates a regression fix that switches the local onboarding default tools.profile from "messaging" to "coding", restoring filesystem/runtime tools (read/write/edit/exec) out of the box for local coding workflows while keeping the profile bounded (not full). The change is propagated consistently across the source constant, tests, and five documentation files.

  • src/commands/onboard-config.ts: ONBOARDING_DEFAULT_TOOLS_PROFILE constant changed from "messaging" to "coding". "coding" is a valid ToolProfileId ("minimal" | "coding" | "messaging" | "full"), and the ??-guard in applyOnboardingLocalWorkspaceConfig correctly preserves any explicitly configured profile.
  • src/commands/onboard-config.test.ts: New test explicitly asserts the constant value; existing behavioral tests were updated to match.
  • src/commands/onboard-non-interactive.gateway.test.ts: onHelloOk callback type was widened to (hello?: { features?: { methods?: string[] } }) => void across all three type-sites and the start() mock now passes a realistic hello payload — aligns with the real GatewayClient interface. The tools.profile assertion was updated from "messaging" to "coding".
  • Docs (configuration-reference.md, wizard.md, onboarding.md, wizard-cli-reference.md, wizard.md): All references to the old default were updated to "coding" with improved framing around what the profile enables.

Confidence Score: 5/5

  • This PR is safe to merge — it is a focused, well-tested default value change with no logic alterations.
  • The change is a single constant swap to a valid enum value, backed by updated unit and integration tests, and comprehensive doc updates. No behavioral logic was modified; the preservation guard for explicit profiles is unchanged. The bundled onHelloOk type fix is consistent across all call sites and aligns the mock with the real interface.
  • No files require special attention.

Last reviewed commit: c30ac84

@cgdusek

This comment was marked as spam.

@cgdusek

This comment was marked as spam.

@cgdusek

This comment was marked as spam.

@cgdusek cgdusek force-pushed the codex/onboard-default-tools-profile-coding-clean branch from c30ac84 to 5af637c Compare March 6, 2026 17:56
@cgdusek

This comment was marked as spam.

@openclaw-barnacle
Copy link

Closing this PR because the author has more than 10 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands Command implementations docs Improvements or additions to documentation gateway Gateway runtime r: too-many-prs size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant