Skip to content

Bugfix/fix alias consistency handler#42

Merged
DivineThreepwood merged 2 commits into
devfrom
bugfix/fix_alias_consistency_handler
Jan 6, 2022
Merged

Bugfix/fix alias consistency handler#42
DivineThreepwood merged 2 commits into
devfrom
bugfix/fix_alias_consistency_handler

Conversation

@DivineThreepwood

@DivineThreepwood DivineThreepwood commented Jan 6, 2022

Copy link
Copy Markdown
Member

📜 Description

Changes proposed in this pull request:

  • Fix alias consistency handler by removing special but useless sandbox handling.
  • Port UnitAliasGenerationConsistencyHandler to Kotlin
  • Add bco-visual-remote to default util collection.
  • Make Com Port and Host configurable via JPs for bco-console and bco-visual-remote
  • Remote JCenter from maven repository collection.
  • Downgrade Kotlin compiler version to jvm 11 to be consistent with the java compiler declared version.

@pLeminoq pLeminoq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe mention that the target java version of the kotlin compiler was changed and that kotlin and gradle were updated.

@DivineThreepwood DivineThreepwood merged commit 231fd08 into dev Jan 6, 2022
@DivineThreepwood DivineThreepwood deleted the bugfix/fix_alias_consistency_handler branch January 11, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants