feat(tools): allow specifying paths instead of auto installing#488
Open
olisikh wants to merge 3 commits intonvim-java:mainfrom
Open
feat(tools): allow specifying paths instead of auto installing#488olisikh wants to merge 3 commits intonvim-java:mainfrom
olisikh wants to merge 3 commits intonvim-java:mainfrom
Conversation
|
I am currently using this and is semi-required for a nice working setup of nvim-java with NixOS (from what I can tell). It works well (although I haven't tested the vscode extensions since I leave those disabled). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds extra configuration property per each tool called
path.If the
pathis specified,nvim-javatries to resolve the tool by the path, if it can't andauto_install = true, it would download it, ifauto_install = falsean error would be shown.The cache path is computed with extra hash to avoid cache collisions when switching tools. If java is auto-installed, the old cache path strategy is used (no hashing for backward compatiblity).
Some (or all?) jdtls distributions do not have
config_mac_armfile, onlyconfig_macmaking jdtls to fail instantly.Instead of failing instantly another attempt is made to resolve config by OS name.
I believe this is an important change for people who do not like their tools downloaded randomly from the internet.
This change should not have any breaking changes, but don't take my words for granted. I have tested this change and it works well.
Would be happy to hear back and adjust if necessary, thanks a bunch!