MAINT: Remove sys.version checks#15335
Merged
Merged
Conversation
eric-wieser
reviewed
Jan 16, 2020
eric-wieser
reviewed
Jan 16, 2020
eric-wieser
reviewed
Jan 16, 2020
sethtroisi
force-pushed
the
sys_version_easy
branch
from
3cc0e05 to
e66b97d
Compare
mattip
reviewed
Jan 16, 2020
mattip
left a comment
mattip
left a comment
Member
There was a problem hiding this comment.
Only a few style nits. In general, I tried to flag import builtins, it usually indicates a hacky solution to a problem and causes a very small performance penalty. Also, there are some strange import semantics where python2 is using relative imports but python3 changed to absolute.
sethtroisi
force-pushed
the
sys_version_easy
branch
from
e66b97d to
2ff3229
Compare
sethtroisi
commented
Jan 16, 2020
sethtroisi
force-pushed
the
sys_version_easy
branch
from
2ff3229 to
0828ecd
Compare
mwtoews
suggested changes
Jan 17, 2020
mwtoews
left a comment
mwtoews
left a comment
Contributor
There was a problem hiding this comment.
Just a few imports to remove or sort/group at the top
Contributor
Author
|
These are wonderful comments mwtoews I'm on vacation but will fix when I'm back |
sethtroisi
force-pushed
the
sys_version_easy
branch
from
0828ecd to
9cbf332
Compare
mwtoews
approved these changes
Jan 20, 2020
Member
|
There are merge conflicts |
mattip
reviewed
Jan 20, 2020
mattip
left a comment
mattip
left a comment
Member
There was a problem hiding this comment.
There are some comments still open, and a few follow-on comments as well.
sethtroisi
force-pushed
the
sys_version_easy
branch
from
9cbf332 to
9a21ec8
Compare
Contributor
Author
|
Addressed @mattip's comments, fixed merge conflict, and did another quick pass over all the changes. |
Member
|
Thanks @sethtroisi |
Contributor
Author
|
Thanks for all the comments and pointers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More sys.version cleanups (these are not limited to test files like #15305 was), after this change only a handful sys.versions exist which I'll add remove/convert/simplify in a final PR.
#15306