dgram: pass null as error on successful send() - #5929
Merged
Merged
Conversation
Contributor
|
LGTM if CI is happy |
Member
|
LGTM if CI doesn't reveal anything interesting |
Contributor
Prior to c9fd9e2, UDP sockets would callback with a null error on successful send() calls. The current behavior is to pass 0 as the error. This commit restores the previous, more expected behavior. PR-URL: nodejs#5929 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Contributor
Author
|
Thanks for the reviews. Landed in 4bc1ccc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
dgram
Description of change
Prior to c9fd9e2, UDP sockets would callback with a
nullerror on successfulsend()calls. The current behavior is to pass 0 as the error. This commit restores the previous, more expected behavior.