src,deps: backport and use non-deprecated V8 methods with isolate - #22531
Closed
targos wants to merge 6 commits into
Closed
src,deps: backport and use non-deprecated V8 methods with isolate#22531targos wants to merge 6 commits into
targos wants to merge 6 commits into
Conversation
nodejs-github-bot
added
c++
cjihrig
approved these changes
Aug 26, 2018
Member
Author
danbev
approved these changes
Aug 27, 2018
addaleax
approved these changes
Aug 27, 2018
jasnell
approved these changes
Aug 27, 2018
Member
Author
|
Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20331/ |
This overload was added in V8 6.9 and the one without isolate was removed in V8 7.0. Refs: v8/v8@8a011b5
These overloads were added in V8 6.9 and the ones without the isolate parameter were removed in V8 7.0. Refs: v8/v8@8a011b5
This overload was added in V8 6.9 and the one without the isolate parameter was removed in V8 7.0. Refs: v8/v8@3dd5c6f
targos
force-pushed
the
v8-isolate-everywhere
branch
from
August 29, 2018 10:25
9508242 to
fc0b211
Compare
Member
Author
|
Landed in 2584052...b2f0cfa |
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22521
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes