Skip to content

test: added test for indexed properties - #11769

Closed
AnnaMag wants to merge 1 commit into
nodejs:masterfrom
AnnaMag:test_indexed_properties
Closed

test: added test for indexed properties#11769
AnnaMag wants to merge 1 commit into
nodejs:masterfrom
AnnaMag:test_indexed_properties

Conversation

@AnnaMag

@AnnaMag AnnaMag commented Mar 9, 2017

Copy link
Copy Markdown
Member

Currently, indexed properties are correctly copied
onto the sandbox by CopyProperties().
This will break when CopyProperties() is removed
after adjusting NamedPropertyHandlerConfiguration
config() to use property callbacks from the new
V8 API. To fix it, we will set a config for indexed
properties.

This test is a preparation step for the patch
that removes CopyProperties().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants