fix: change getStatus() return type to string#493
Open
Frederick888 wants to merge 1 commit into
Open
Conversation
Promise<string> was added in [1] but its implementations only ever returned strings. I suspect it was just caught in the similar changes to other methods. [1] node-cron@f10ad8a#diff-1d52084a4265cb2ab89812078b6452920da6eec1136eb9268bfd710b73aab563L54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promise<string> was added in [1] but its implementations only ever
returned strings. I suspect it was just caught in the similar changes to
other methods.
[1] f10ad8a#diff-1d52084a4265cb2ab89812078b6452920da6eec1136eb9268bfd710b73aab563L54
Though it's perhaps better to export and use
TaskStateinstead ofstringwhile we are at it? Happy to do this if you agree.