make Slf4JLoggerFactory be singleton#11253
Merged
normanmaurer merged 5 commits intonetty:4.1from May 17, 2021
Merged
Conversation
NiteshKant
reviewed
May 13, 2021
common/src/main/java/io/netty/util/internal/logging/Slf4JLoggerFactory.java
Show resolved
Hide resolved
…g the behavior of the previous exposed INSTANCE field
NiteshKant
approved these changes
May 14, 2021
Member
NiteshKant
left a comment
NiteshKant
left a comment
There was a problem hiding this comment.
LGTM after the last comment is addressed.
common/src/main/java/io/netty/util/internal/logging/Slf4JLoggerFactory.java
Outdated
Show resolved
Hide resolved
NiteshKant
approved these changes
May 14, 2021
normanmaurer
approved these changes
May 17, 2021
normanmaurer
pushed a commit
that referenced
this pull request
May 17, 2021
Motivation: The current initialization of Slf4JLoggerFactory is not singleton. Modification: Use Slf4JLoggerFactory.INSTANCE to initialize Slf4JLoggerFactory. Result: The instance of Slf4JLoggerFactory became a singleton.
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: The current initialization of Slf4JLoggerFactory is not singleton. Modification: Use Slf4JLoggerFactory.INSTANCE to initialize Slf4JLoggerFactory. Result: The instance of Slf4JLoggerFactory became a singleton.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The current initialization of Slf4JLoggerFactory is not singleton.
Modification:
Use
Slf4JLoggerFactory.INSTANCEto initializeSlf4JLoggerFactory.Result:
The instance of Slf4JLoggerFactory became a singleton.