fix(ci): pin dogfood workflow to semvertag>=0.3.1#8
Merged
Conversation
0.3.0's branch-prefix strategy doesn't recognize GitHub PR merge subjects; the dogfood workflow silently no-op'd on every merge. 0.3.1 fixed this. Tighten the floor so the workflow can't resolve to the known-broken 0.3.0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.3.0 has the branch-prefix merge-detection bug (fixed in 0.3.1). The dogfood workflow's
>=0.3,<1floor allowed resolving to 0.3.0, which silently no-op'd on every GitHub PR merge. Tighten to>=0.3.1,<1so the workflow always uses a fixed version.This PR's source branch is
bugfix/..., so once merged, the dogfood workflow itself runs against the merge commit and — using the newly-pinned 0.3.1 — should successfully recognize theMerge pull request #N from .../bugfix/...subject, computepatch, and create tag0.3.2.This is the moment of truth for the GitHub provider end-to-end.
Test plan
Merge pull request #N from modern-python/bugfix/dogfood-floor-0.3.1api.github.com/repos/modern-python/semvertag/git/refswith{"ref": "refs/tags/0.3.2", "sha": ...}git fetch --tags origin && git tag --sort=-v:refname | head -3shows 0.3.2 alongside 0.3.1 and 0.3.0🤖 Generated with Claude Code