Skip to content

feat(story-2.2): phase-shortcut decorators @before_request, @after_response, @on_error #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 10 commits into from
May 31, 2026
Merged

feat(story-2.2): phase-shortcut decorators @before_request, @after_response, @on_error #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6cfc9fa
docs(story-2.2): design for phase-shortcut decorators
lesnik512 May 31, 2026
2527bec
feat(story-2.2): @before_request decorator factory
lesnik512 May 31, 2026
38bfc5d
feat(story-2.2): @after_response decorator factory
lesnik512 May 31, 2026
68bd4b0
feat(story-2.2): @on_error decorator factory
lesnik512 May 31, 2026
c9e3413
test(story-2.2): cross-decorator behavior (Protocol, chain, repr)
lesnik512 May 31, 2026
3c413d6
feat(story-2.2): re-export decorators; fix engineering.md naming; CHA…
lesnik512 May 31, 2026
447c52a
fix(story-2.2): _FailingTransport.stream annotation matches Transport…
lesnik512 May 31, 2026
6d6ff07
docs(story-2.2): implementation plan for phase-shortcut decorators
lesnik512 May 31, 2026
a26a036
test(story-2.2): extend repr test to cover after_response and on_error
lesnik512 May 31, 2026
164e72d
refactor(tests): hoist `import httpware` to module top-level
lesnik512 May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
- `Transport` protocol (`@runtime_checkable`) and default `Httpx2Transport` adapter; `StreamResponse` placeholder for Story 4.1 protocol typing; the wire `method` is uppercased at the seam and `httpx2` exceptions (`TimeoutException`, `HTTPError`, `InvalidURL`, `CookieConflict`, and the closed-client `RuntimeError`) are mapped to `httpware.TimeoutError` / `httpware.TransportError` (with the original exception's message preserved on the mapped instance) so no `httpx2` exception escapes the library; lazy `httpx2.AsyncClient` construction is guarded by an `asyncio.Lock` so concurrent first-calls share one client; `httpx2` is confined to `src/httpware/transports/httpx2.py` (Story 1.4).
- `ResponseDecoder` protocol (`@runtime_checkable`) and default `PydanticDecoder` adapter — single-parse-pass JSON decoding via `pydantic.TypeAdapter.validate_json(bytes)`; a module-level `@functools.lru_cache(maxsize=None)` factory (`_get_adapter`) memoizes one `TypeAdapter` per `response_model` across the process so warm-path requests pay zero adapter-construction cost; `pydantic.ValidationError` surfaces unchanged to the caller (Story 1.5).
- `Middleware` protocol (`@runtime_checkable`) and `Next` callable type alias (`Callable[[Request], Awaitable[Response]]`); private `compose(middlewares, transport)` chain composer at `httpware._internal.chain` using a recursive closure fold with `transport.__call__` as the bottom of the chain. No exception handling inside `compose`, so `asyncio.CancelledError` and user-raised exceptions propagate untouched (Story 2.1).
- Phase-shortcut decorators `@before_request`, `@after_response`, `@on_error` for lifecycle hooks without authoring a full `Middleware` class. `@on_error` catches `Exception` only (so `asyncio.CancelledError` propagates); its handler may return a `Response` to recover or `None` to re-raise (Story 2.2).

[Unreleased]: https://github.com/modern-python/httpware/commits/main
2 changes: 1 addition & 1 deletion docs/engineering.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Twenty-seven stories remain. Topic slugs in `docs/superpowers/specs/` and `docs/
### Epic 2 — Compose request-handling logic via middleware

- **2-1** `Middleware` protocol, `Next` type, chain composition.
- **2-2** Phase shortcut decorators (`@on_request`, `@on_response`, `@on_error`).
- **2-2** Phase shortcut decorators (`@before_request`, `@after_response`, `@on_error`).
- **2-3** `Request` immutability helpers (`with_headers`, `with_cookie`, `with_extension`, etc.).
- **2-4** Auth coercion as middleware.
- **2-5** Wire middleware into `AsyncClient`.
Expand Down
Loading
Loading