Add setting to show commit SHAs in tree - #8840

src/view/treeNodes/commitNode.ts:51

• The description is computed once in the constructor, so toggling showCommitShaInTree may not update existing CommitNode instances even if the parent refreshes. To ensure the UI reflects the current setting, compute/update description inside getTreeItem() (or recompute on refresh) rather than only in the constructor.

		this.description = this._getDescription();
	}

	private _getDescription(): string | undefined {
		const date = this.commit.commit.author?.date ? dateFromNow(this.commit.commit.author.date) : undefined;
		if (!vscode.workspace.getConfiguration(PR_SETTINGS_NAMESPACE).get<boolean>(SHOW_COMMIT_SHA_IN_TREE, false)) {
			return date;
		}
		const shortSha = this.commit.sha.substring(0, 7);
		return date ? `${shortSha} · ${date}` : shortSha;

	}

src/view/treeNodes/commitsCategoryNode.ts:48

• Use the standard capitalization 'SHA' instead of 'Sha' in the log message.

				Logger.appendLine(`Commit Sha display setting has changed, refreshing Commits node`, PR_TREE);

package.nls.json:193

• This description string is missing a trailing period, which is inconsistent with nearby setting descriptions.

	"githubPullRequests.showCommitShaInTree.description": "Shows the abbreviated commit SHA in the tree view",

src/view/treeNodes/commitNode.ts:41

• The leading underscore is typically redundant on private methods in TypeScript and can be inconsistent with common conventions. Consider renaming to getDescription() (or computeDescription()) for clarity and consistency.

	private _getDescription(): string | undefined {

src/view/treeNodes/commitNode.ts:46

• The new setting-driven formatting logic in _getDescription is not covered by automated tests. Since the repo already has unit tests for tree nodes under src/test/view/treeNodes, it would be good to add a focused test verifying the description output for (1) setting disabled, (2) enabled + date, and (3) enabled + no date.

	private _getDescription(): string | undefined {
		const date = this.commit.commit.author?.date ? dateFromNow(this.commit.commit.author.date) : undefined;
		if (!vscode.workspace.getConfiguration(PR_SETTINGS_NAMESPACE).get<boolean>(SHOW_COMMIT_SHA_IN_TREE, false)) {
			return date;
		}
		const shortSha = this.commit.sha.substring(0, 7);
		return date ? `${shortSha} · ${date}` : shortSha;

src/view/treeNodes/commitNode.ts:48

• CommitNode already stores sha on the instance (this.sha = commit.sha), but _getDescription re-reads it from this.commit.sha. Using this.sha avoids duplication and keeps the source of truth consistent.

		const shortSha = this.commit.sha.substring(0, 7);
		return date ? `${shortSha} · ${date}` : shortSha;

	}

src/view/treeNodes/commitNode.ts:46

• New config-driven description formatting is introduced here but isn’t covered by unit tests. The repo already has Mocha tests for tree nodes under src/test/view/treeNodes/ and patterns for stubbing vscode.workspace.getConfiguration (e.g. src/test/issues/stateManager.test.ts). Consider adding a CommitNode test that verifies: (1) setting disabled => description is just the relative date/undefined, (2) setting enabled + date => <shortSha> · <relativeDate>, (3) setting enabled + no date => <shortSha> (use fake timers to make dateFromNow deterministic).

		if (!vscode.workspace.getConfiguration(PR_SETTINGS_NAMESPACE).get<boolean>(SHOW_COMMIT_SHA_IN_TREE, false)) {
			return date;
		}
		const shortSha = this.sha.substring(0, 7);
		return date ? `${shortSha} · ${date}` : shortSha;