Skip to content

Revert "Create pyproject.toml"#30

Merged
dciborow merged 1 commit into
mainfrom
revert-20-dciborow/pyproject
May 2, 2022
Merged

Revert "Create pyproject.toml"#30
dciborow merged 1 commit into
mainfrom
revert-20-dciborow/pyproject

Conversation

@dciborow
Copy link
Copy Markdown
Contributor

@dciborow dciborow commented May 2, 2022

Reverts #20

@dciborow dciborow merged commit c321fcb into main May 2, 2022
@@ -0,0 +1,13 @@
def hello_world(i: int = 0) -> str:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [pyright] reported by reviewdog 🐶
Function with declared type of "str" must return value
  Type "None" cannot be assigned to type "str" (reportGeneralTypeIssues)



def hello_goodbye():
hello_world("x")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [pyright] reported by reviewdog 🐶
Argument of type "Literal['x']" cannot be assigned to parameter "i" of type "int" in function "hello_world"
  "Literal['x']" is incompatible with "int" (reportGeneralTypeIssues)

Comment thread tests/test_methods.py
from python_package.hello_world import hello_world
import pytest

from ai-python-package.hello_world import hello_world
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [pyright] reported by reviewdog 🐶
Expected "import"

Comment thread tests/test_methods.py
from python_package.hello_world import hello_world
import pytest

from ai-python-package.hello_world import hello_world
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [pyright] reported by reviewdog 🐶
Statements must be separated by newlines or semicolons

Comment thread tests/test_methods.py
from python_package.hello_world import hello_world
import pytest

from ai-python-package.hello_world import hello_world
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [pyright] reported by reviewdog 🐶
Statements must be separated by newlines or semicolons

Comment thread tests/test_methods.py
from python_package.hello_world import hello_world
import pytest

from ai-python-package.hello_world import hello_world
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [pyright] reported by reviewdog 🐶
Import "ai" could not be resolved (reportMissingImports)

Comment thread tests/test_methods.py
from python_package.hello_world import hello_world
import pytest

from ai-python-package.hello_world import hello_world
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [pyright] reported by reviewdog 🐶
Import "hello_world" could not be resolved (reportMissingImports)

Comment thread tests/test_methods.py
from python_package.hello_world import hello_world
import pytest

from ai-python-package.hello_world import hello_world
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [pyright] reported by reviewdog 🐶
"python" is not defined (reportUndefinedVariable)

Comment thread tests/test_methods.py
from python_package.hello_world import hello_world
import pytest

from ai-python-package.hello_world import hello_world
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [pyright] reported by reviewdog 🐶
"package" is not defined (reportUndefinedVariable)

Comment thread tests/test_methods.py
from python_package.hello_world import hello_world
import pytest

from ai-python-package.hello_world import hello_world
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [pyright] reported by reviewdog 🐶
Expression value is unused (reportUnusedExpression)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant