Use project's java runtime to launch the application#319
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
testforstephen
force-pushed
the
jinbo_javaruntime
branch
from
3a35ae8 to
5d651e1
Compare
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
testforstephen
force-pushed
the
jinbo_javaruntime
branch
from
5d651e1 to
c36a889
Compare
| * with an error before a connection could be established. | ||
| */ | ||
| public static IDebugSession launch(VirtualMachineManager vmManager, | ||
| String javaExec, |
There was a problem hiding this comment.
When adding a parameter to the signature, it's suggested that the new param is added to the end of the list. Other languages do that because they support default parameters. While Java does not have that, it's still recommended to keep the convention.
| if (StringUtils.isNotEmpty(DebugSettings.getCurrent().javaHome)) { | ||
| if (isValidJavaExec(javaExec)) { | ||
| String vmExec = new File(javaExec).getName(); | ||
| String javaHome = new File(javaExec).getParentFile().getParentFile().getAbsolutePath(); |
There was a problem hiding this comment.
This looks tricky. Do we really need to pass this value to launch the JVM since we already have the path to the executable?
There was a problem hiding this comment.
This is in order to keep compatible with JDI Socket LaunchingConnectorImpl https://github.com/eclipse/eclipse.jdt.debug/blob/master/org.eclipse.jdt.debug/jdi/org/eclipse/jdi/internal/connect/SocketLaunchingConnectorImpl.java#L188, where it uses javaHome + separator + vmExec to construct the command line.
Currently when launching in debug console, we're still using SocketLaunchingConnector to construct the command line, so need resolve the javaHome and vmExec from the path and pass them as the connector arguments.
Another option is to use ListeningConnector instead, like what launchInTerminal did, the debugger can leverage the javaExec path directly. Let's track the refactor improvement in the issue microsoft/vscode-java-debug#760
| IJavaProject targetProject = null; | ||
| if (StringUtils.isNotBlank(projectName)) { | ||
| targetProject = JdtUtils.getJavaProject(projectName); | ||
| } else { |
There was a problem hiding this comment.
If a project is not specified, should we just use whatever JVM that the debugger is using to launch the app?
There was a problem hiding this comment.
In launch.json, project info is optional. In the case of undefined, the debugger will try to resolve the project info from the main class. See the else branch.
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
|
@akaroml PR updated |
2 participants
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
This PR requires microsoft/vscode-java-debug#758