Follow up to PR #41512 - #41642
Open
Feng Wang (chemwolf6922) wants to merge 1 commit into
Open
Follow up to PR #41512#41642Feng Wang (chemwolf6922) wants to merge 1 commit into
Feng Wang (chemwolf6922) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Feng Wang (chemwolf6922)
September 18, 2026 07:08
View session
6 tasks
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The reviewed changes contain an unresolved build failure and a test cleanup failure risk.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This follow-up simplifies cgroup cleanup handling and adds systemd boot-timeout regression coverage.
Changes:
- Moves cgroup cleanup retry logic into the debug shell.
- Removes redundant cgroup namespace restoration.
- Adds
SystemdBootTimeoutcoverage.
File summaries
| File | Summary |
|---|---|
test/windows/UnitTests.cpp |
Adds timeout coverage and updates cgroup cleanup validation; keep-alive reset may fail after VM shutdown (moderate, 1 vote). |
src/linux/init/init.cpp |
Removes namespace restoration but leaves an unused variable, causing a -Wall -Werror build failure (critical, 1 vote). |
Review details
Suppressed comments (1)
test/windows/UnitTests.cpp:8172
- The guest script powers off the VM while
keepAlive2is still active, but the next line callsWslKeepAlive::Reset(). That method unconditionally writes to the keep-alive process's stdin and throws on a broken pipe (test/windows/Common.cpp:1217-1224), so once the forced shutdown terminates thatwsl.exeprocess this test can fail during cleanup. Avoid resetting a keep-alive after tearing down its VM, or make the cleanup tolerate an already-terminated process.
keepAlive2.Reset();
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This is a follow up to PR #41512
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Add / modified tests:
UnitTests::UnitTests::SystemdBootTimeout
UnitTests::UnitTests::IsolatedCgroupLayout
UnitTests::UnitTests::IsolatedCgroupLayoutSystemd
UnitTests::UnitTests::IsolatedCgroupLayoutOverridesV1