Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
microsoft
/
TypeScript
Public
Notifications
You must be signed in to change notification settings
Fork
13.8k
Star
111k
Code
Issues
5k+
Pull requests
80
Actions
Projects
Wiki
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Wiki
Security and quality
Insights
Improve reuse of nodes in signatures with type mapping
- #58546
#58546
Merged
Wesley Wigham (weswigham)
merged 17 commits into
microsoft:main
microsoft/TypeScript:main
from
bloomberg:isolated-declarations-mapped-sig-reuse
bloomberg/TypeScript:isolated-declarations-mapped-sig-reuse
Copy head branch name to clipboard
May 23, 2024
Conversation
Commits
17
(17)
Checks
Files changed
Merged
Improve reuse of nodes in signatures with type mapping
#58546
Wesley Wigham (weswigham)
merged 17 commits into
microsoft:main
microsoft/TypeScript:main
from
bloomberg:isolated-declarations-mapped-sig-reuse
bloomberg/TypeScript:isolated-declarations-mapped-sig-reuse
Copy head branch name to clipboard
Commits
Commits on May 15, 2024
Updated baseline that have better node reuse.
Titian Cernicova-Dragomir (dragomirtitian)
committed
114e936
View commit details
Copy full SHA for 114e936
Browse repository at this point
Type printed in a different way without any change (ReadonlyArray<T>, Array<T>, ())
Titian Cernicova-Dragomir (dragomirtitian)
committed
1b4d000
View commit details
Copy full SHA for 1b4d000
Browse repository at this point
Union order is different.
Titian Cernicova-Dragomir (dragomirtitian)
committed
c69b466
View commit details
Copy full SHA for c69b466
Browse repository at this point
Names and types not resolved and preserved as written in source.
Titian Cernicova-Dragomir (dragomirtitian)
committed
1765bef
View commit details
Copy full SHA for 1765bef
Browse repository at this point
Default parameters not added
Titian Cernicova-Dragomir (dragomirtitian)
committed
1ecd410
View commit details
Copy full SHA for 1ecd410
Browse repository at this point
Undefined preserved from the original type.
Titian Cernicova-Dragomir (dragomirtitian)
committed
a85b6c5
View commit details
Copy full SHA for a85b6c5
Browse repository at this point
Undefined not added to optional properties.
Titian Cernicova-Dragomir (dragomirtitian)
committed
8db4971
View commit details
Copy full SHA for 8db4971
Browse repository at this point
Trivial diffs.
Titian Cernicova-Dragomir (dragomirtitian)
committed
4062e36
View commit details
Copy full SHA for 4062e36
Browse repository at this point
Type preserved even though original type had error.
Titian Cernicova-Dragomir (dragomirtitian)
committed
00a7bd4
View commit details
Copy full SHA for 00a7bd4
Browse repository at this point
Misc baseline update
Titian Cernicova-Dragomir (dragomirtitian)
committed
c2103f0
View commit details
Copy full SHA for c2103f0
Browse repository at this point
Types were wrong in the original baseline
Titian Cernicova-Dragomir (dragomirtitian)
committed
6ec7c6b
View commit details
Copy full SHA for 6ec7c6b
Browse repository at this point
Updated test and some declaration baselines.
Titian Cernicova-Dragomir (dragomirtitian)
committed
4f304e5
View commit details
Copy full SHA for 4f304e5
Browse repository at this point
Code & fixes for four-slash tests
Titian Cernicova-Dragomir (dragomirtitian)
committed
4cab9e1
View commit details
Copy full SHA for 4cab9e1
Browse repository at this point
Trivial reuse after merge with master.
Titian Cernicova-Dragomir (dragomirtitian)
committed
da08515
View commit details
Copy full SHA for da08515
Browse repository at this point
Updated baseline.
Titian Cernicova-Dragomir (dragomirtitian)
committed
7c43bf9
View commit details
Copy full SHA for 7c43bf9
Browse repository at this point
Improve mapping of types in type node builder.
Titian Cernicova-Dragomir (dragomirtitian)
committed
52c6e2f
View commit details
Copy full SHA for 52c6e2f
Browse repository at this point
Commits on May 20, 2024
Merge remote-tracking branch 'remotes/origin/main' into isolated-declarations-mapped-sig-reuse
Titian Cernicova-Dragomir (dragomirtitian)
committed
69daca1
View commit details
Copy full SHA for 69daca1
Browse repository at this point
You can’t perform that action at this time.