Fixed array expression spreads into variadic const calls by Andarist · Pull Request #52845 · microsoft/TypeScript

Mateusz Burzyński (Andarist) · 2023-02-18T22:29:12Z

I noticed the issue while working on another PR here:

declare function foo<const T extends readonly unknown[]>(...args: T): T;
foo(...[1, 'bar']); // should be OK
foo(true, ...[1, 'bar']); // OK

declare function foo2<T extends readonly unknown[]>(...args: T): T;
foo2(...[1, 'bar']); // OK
foo2(true, ...[1, 'bar']); // OK

declare function foo3<T extends unknown[]>(...args: T): T;
foo3(...[1, 'bar']); // OK
foo3(true, ...[1, 'bar']); // OK

TS playground

fixes #53149

TypeScript Bot (typescript-bot) · 2023-02-18T22:29:25Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Mateusz Burzyński (Andarist) · 2023-02-18T22:31:54Z

 f2(1, 2, 3, 4, 5);
 f2(1, 2, 3, 4, 5, 6, 7);
-f2(...[1], 2, 3, 4, 5, 6);
+f2(1, 2, 3, 4, 5, ...[6, 7]);


I changed this since the previous version became OK with this PR - spreading a fixed array expression into a call is now treated just as if positional arguments would be provided (thanks to getEffectiveCallArguments creating synthetic expressions)

Mateusz Burzyński (Andarist) · 2023-02-18T22:35:27Z

        const inDestructuringPattern = isAssignmentTarget(node);
-        const inConstContext = isConstContext(node);
+        const isSpreadIntoCallOrNew = isSpreadElement(node.parent) && isCallOrNewExpression(node.parent.parent);
+        const inConstContext = isSpreadIntoCallOrNew || isConstContext(node);


initially, I wanted to adjust isConstContext - but spread arguments never have contextual types + asking for a contextual type of an argument calls getEffectiveCallArguments and we are within this call already, so it was creating an infinite loop

I was looking into other ways to check for the const context for such spread expressions but I couldn't figure out anything since I can't even check the signature (it's still resolvingSignature at this point).

Nathan Shively-Sanders (sandersn) · 2023-03-07T19:04:40Z

Mateusz Burzyński (@Andarist) could you create a bug to track this as well? The problem itself seems pretty straightforward, but it would help us track bugs better.

Mateusz Burzyński (Andarist) · 2023-03-07T21:10:17Z

Nathan Shively-Sanders (@sandersn) created #53149 for this issue

Jake Bailey (jakebailey) · 2023-03-08T00:00:06Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-03-08T00:00:09Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at 4550763. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-08T00:00:09Z

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at 4550763. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-03-08T00:00:09Z

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at 4550763. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-08T00:00:09Z

Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 4550763. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-08T00:00:09Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at 4550763. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-03-08T00:00:10Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at 4550763. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-08T00:02:20Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/148751/artifacts?artifactName=tgz&fileId=5D2B715FC1004FC8A38CF36F7C497E0FAB129C486744F6EFF7E066B5A4555CD002&fileName=/typescript-5.1.0-insiders.20230308.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-52845-10".;

TypeScript Bot (typescript-bot) · 2023-03-08T00:18:03Z

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52845/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-03-08T01:35:37Z

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52845/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

5 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2554: Expected 0-1 arguments, but got 2.
- src/vs/workbench/browser/parts/views/treeView.ts#L1401
error TS2554: Expected 0-1 arguments, but got 3.
- src/vs/workbench/contrib/timeline/browser/timelinePane.ts#L1100

TypeScript Bot (typescript-bot) · 2023-03-08T02:03:41Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: lodash
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/lodash/lodash-tests.ts:729:9
ERROR: 729:9  expect  TypeScript@local expected type to be:
  never
got:
  AbcObject

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: inquirer
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/inquirer/inquirer-tests.ts:232:5
ERROR: 232:5  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 234:9  expect  TypeScript@local compile error: 
No overload matches this call.
  Overload 1 of 2, '(observerOrNext?: Partial<Observer<{ name: string; answer: any; }>> | ((value: { name: string; answer: any; }) => void) | undefined): Subscription', gave the following error.
    Type '(value: {    name_: string;    answer: number;}) => void' is not assignable to type '(value: { name: string; answer: any; }) => void'.
      Types of parameters 'value' and 'value' are incompatible.
        Property 'name_' is missing in type '{ name: string; answer: any; }' but required in type '{ name_: string; answer: number; }'.
  Overload 2 of 2, '(next?: ((value: { name: string; answer: any; }) => void) | null | undefined, error?: ((error: any) => void) | null | undefined, complete?: (() => void) | null | undefined): Subscription', gave the following error.
    Argument of type '{ next: (value: {    name_: string;    answer: number;}) => void; }' is not assignable to parameter of type '(value: { name: string; answer: any; }) => void'.
      Object literal may only specify known properties, and 'next' does not exist in type '(value: { name: string; answer: any; }) => void'.
ERROR: 260:5  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 262:9  expect  TypeScript@local compile error: 
No overload matches this call.
  Overload 1 of 2, '(observerOrNext?: Partial<Observer<QuestionAnswer<{ str: string; num: number; }>>> | ((value: QuestionAnswer<{ str: string; num: number; }>) => void) | undefined): Subscription', gave the following error.
    Type '(value: {    name: string;    answer: number;}) => void' is not assignable to type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.
      Types of parameters 'value' and 'value' are incompatible.
        Type 'QuestionAnswer<{ str: string; num: number; }>' is not assignable to type '{ name: string; answer: number; }'.
          Type '{ name: "str"; answer: string; }' is not assignable to type '{ name: string; answer: number; }'.
            Types of property 'answer' are incompatible.
              Type 'string' is not assignable to type 'number'.
  Overload 2 of 2, '(next?: ((value: QuestionAnswer<{ str: string; num: number; }>) => void) | null | undefined, error?: ((error: any) => void) | null | undefined, complete?: (() => void) | null | undefined): Subscription', gave the following error.
    Argument of type '{ next: (value: {    name: string;    answer: number;}) => void; }' is not assignable to parameter of type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.
      Object literal may only specify known properties, and 'next' does not exist in type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: zen-observable
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/zen-observable/test/esm-tests.ts:37:9
ERROR: 37:9  expect  TypeScript@local expected type to be:
  number[]
got:
  [number]
ERROR: 81:9  expect  TypeScript@local expected type to be:
  number[]
got:
  [number]

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: inquirer/v8
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/inquirer/v8/inquirer-tests.ts:234:5
ERROR: 234:5  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 236:9  expect  TypeScript@local compile error: 
No overload matches this call.
  Overload 1 of 2, '(observerOrNext?: Partial<Observer<{ name: string; answer: any; }>> | ((value: { name: string; answer: any; }) => void) | undefined): Subscription', gave the following error.
    Type '(value: {    name_: string;    answer: number;}) => void' is not assignable to type '(value: { name: string; answer: any; }) => void'.
      Types of parameters 'value' and 'value' are incompatible.
        Property 'name_' is missing in type '{ name: string; answer: any; }' but required in type '{ name_: string; answer: number; }'.
  Overload 2 of 2, '(next?: ((value: { name: string; answer: any; }) => void) | null | undefined, error?: ((error: any) => void) | null | undefined, complete?: (() => void) | null | undefined): Subscription', gave the following error.
    Argument of type '{ next: (value: {    name_: string;    answer: number;}) => void; }' is not assignable to parameter of type '(value: { name: string; answer: any; }) => void'.
      Object literal may only specify known properties, and 'next' does not exist in type '(value: { name: string; answer: any; }) => void'.
ERROR: 262:5  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 264:9  expect  TypeScript@local compile error: 
No overload matches this call.
  Overload 1 of 2, '(observerOrNext?: Partial<Observer<QuestionAnswer<{ str: string; num: number; }>>> | ((value: QuestionAnswer<{ str: string; num: number; }>) => void) | undefined): Subscription', gave the following error.
    Type '(value: {    name: string;    answer: number;}) => void' is not assignable to type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.
      Types of parameters 'value' and 'value' are incompatible.
        Type 'QuestionAnswer<{ str: string; num: number; }>' is not assignable to type '{ name: string; answer: number; }'.
          Type '{ name: "str"; answer: string; }' is not assignable to type '{ name: string; answer: number; }'.
            Types of property 'answer' are incompatible.
              Type 'string' is not assignable to type 'number'.
  Overload 2 of 2, '(next?: ((value: QuestionAnswer<{ str: string; num: number; }>) => void) | null | undefined, error?: ((error: any) => void) | null | undefined, complete?: (() => void) | null | undefined): Subscription', gave the following error.
    Argument of type '{ next: (value: {    name: string;    answer: number;}) => void; }' is not assignable to parameter of type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.
      Object literal may only specify known properties, and 'next' does not exist in type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

Jake Bailey (jakebailey) · 2023-03-08T02:11:27Z

I have yet to look at the DT changes, but, that VS Code change actually seems correct given the definition of IAction?

Jake Bailey (jakebailey) · 2023-03-08T02:13:32Z

That inquirer change seems unrelated. Gabriela Araujo Britto (@gabritto)

Jake Bailey (jakebailey) · 2023-03-08T03:42:45Z

The lodash change seems like a actual improvement; I think it's now correctly applying the tuple to the overloads and now one of the arguments is actually typed properly as though it were called with two args.

The zen-observable change seems positive too.

Jake Bailey (jakebailey) · 2023-03-08T03:45:18Z

BTW here's a quick hover of the vscode example today, eek:

Jake Bailey (jakebailey) · 2023-03-08T05:18:24Z

Ignoring the spurious inquirer failure, this looks great to me.

Mateusz Burzyński (Andarist) · 2023-03-08T10:54:19Z

Nice, added the IAction as a test case. Let me know if I should anyhow investigate the inquirer's case.

Jake Bailey (jakebailey) · 2023-03-08T13:52:56Z

Let me know if I should anyhow investigate the inquirer's case.

I don't think you need to; I've seen that exact failure on another PR, so it's probably a glitch in the diff.

TypeScript Bot (typescript-bot) · 2023-03-08T15:54:12Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52845

_Metric	_main	₅₂₈₄₅	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{359,838k (± 0.01%)}	_{359,811k (± 0.01%)}	_~	_359,765k	_359,860k	_{p=0.229 n=6}
_{Parse Time}	_{3.50s (± 0.69%)}	_{3.50s (± 0.84%)}	_~	_3.47s	_3.55s	_{p=0.686 n=6}
_{Bind Time}	_{1.13s (± 1.12%)}	_{1.13s (± 1.03%)}	_~	_1.12s	_1.15s	_{p=1.000 n=6}
_{Check Time}	_{8.65s (± 0.49%)}	_{8.67s (± 0.43%)}	_~	_8.62s	_8.71s	_{p=0.421 n=6}
_{Emit Time}	_{7.42s (± 0.86%)}	_{7.44s (± 0.79%)}	_~	_7.38s	_7.53s	_{p=0.575 n=6}
_{Total Time}	_{20.70s (± 0.42%)}	_{20.75s (± 0.51%)}	_~	_20.60s	_20.90s	_{p=0.471 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{194,540k (± 1.51%)}	_{193,618k (± 1.60%)}	_~	_190,763k	_196,509k	_{p=0.689 n=6}
_{Parse Time}	_{1.48s (± 0.55%)}	_{1.49s (± 0.71%)}	_~	_1.47s	_1.50s	_{p=0.181 n=6}
_{Bind Time}	_{0.77s (± 0.98%)}	_{0.77s (± 0.98%)}	_~	_0.76s	_0.78s	_{p=1.000 n=6}
_{Check Time}	_{9.40s (± 1.06%)}	_{9.37s (± 0.37%)}	_~	_9.33s	_9.42s	_{p=0.936 n=6}
_{Emit Time}	_{2.74s (± 0.68%)}	_{2.73s (± 0.72%)}	_~	_2.72s	_2.77s	_{p=0.743 n=6}
_{Total Time}	_{14.38s (± 0.76%)}	_{14.36s (± 0.32%)}	_~	_14.29s	_14.40s	_{p=0.936 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,848k (± 0.01%)}	_{343,835k (± 0.01%)}	_~	_343,809k	_343,861k	_{p=0.873 n=6}
_{Parse Time}	_{2.63s (± 0.72%)}	_{2.64s (± 0.44%)}	_~	_2.63s	_2.66s	_{p=0.249 n=6}
_{Bind Time}	_{1.01s (± 1.02%)}	_{1.02s (± 1.15%)}	_~	_1.01s	_1.04s	_{p=0.491 n=6}
_{Check Time}	_{7.01s (± 0.55%)}	_{7.03s (± 0.54%)}	_~	_6.97s	_7.07s	_{p=0.420 n=6}
_{Emit Time}	_{4.19s (± 0.93%)}	_{4.21s (± 0.84%)}	_~	_4.16s	_4.25s	_{p=0.462 n=6}
_{Total Time}	_{14.85s (± 0.46%)}	_{14.90s (± 0.39%)}	_~	_14.78s	_14.94s	_{p=0.258 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{299,886k (± 0.01%)}	_{299,881k (± 0.00%)}	_~	_299,864k	_299,897k	_{p=0.575 n=6}
_{Parse Time}	_{2.06s (± 0.71%)}	_{2.05s (± 1.09%)}	_~	_2.02s	_2.09s	_{p=0.550 n=6}
_{Bind Time}	_{1.14s (± 0.78%)}	_{1.14s (± 0.48%)}	_~	_1.14s	_1.15s	_{p=0.341 n=6}
_{Check Time}	_{6.50s (± 0.66%)}	_{6.53s (± 0.55%)}	_~	_6.48s	_6.58s	_{p=0.332 n=6}
_{Emit Time}	_{3.87s (± 0.98%)}	_{3.86s (± 0.72%)}	_~	_3.82s	_3.89s	_{p=1.000 n=6}
_{Total Time}	_{13.56s (± 0.63%)}	_{13.58s (± 0.47%)}	_~	_13.49s	_13.67s	_{p=0.570 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,447k (± 0.00%)}	_{476,449k (± 0.00%)}	_~	_476,426k	_476,479k	_{p=1.000 n=6}
_{Parse Time}	_{3.13s (± 0.77%)}	_{3.13s (± 0.69%)}	_~	_3.09s	_3.15s	_{p=0.871 n=6}
_{Bind Time}	_{0.92s (± 0.56%)}	_{0.91s (± 1.08%)}	_~	_0.90s	_0.93s	_{p=0.191 n=6}
_{Check Time}	_{17.11s (± 0.41%)}	_{17.13s (± 0.70%)}	_~	_16.98s	_17.24s	_{p=0.810 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.16s (± 0.38%)}	_{21.16s (± 0.54%)}	_~	_21.01s	_21.27s	_{p=1.000 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{548,929k (± 0.02%)}	_{549,011k (± 0.03%)}	_~	_548,800k	_549,267k	_{p=0.423 n=6}
_{Parse Time}	_{4.10s (± 0.58%)}	_{4.08s (± 0.77%)}	_~	_4.03s	_4.12s	_{p=0.195 n=6}
_{Bind Time}	_{1.68s (± 0.62%)}	_{1.67s (± 0.63%)}	_~	_1.66s	_1.69s	_{p=0.931 n=6}
_{Check Time}	_{2.79s (± 0.77%)}	_{2.78s (± 0.75%)}	_~	_2.75s	_2.80s	_{p=0.376 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.65s (± 0.38%)}	_{8.61s (± 0.44%)}	_~	_8.57s	_8.68s	_{p=0.052 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,106k (± 0.01%)}	_{359,093k (± 0.00%)}	_~	_359,083k	_359,107k	_{p=0.378 n=6}
_{Parse Time}	_{3.72s (± 0.50%)}	_{3.71s (± 0.36%)}	_~	_3.69s	_3.72s	_{p=0.554 n=6}
_{Bind Time}	_{1.19s (± 0.43%)}	_{1.19s (± 0.00%)}	_~	_1.19s	_1.19s	_{p=0.174 n=6}
_{Check Time}	_{9.45s (± 0.23%)}	_{9.40s (± 0.63%)}	_~	_9.33s	_9.50s	_{p=0.077 n=6}
_{Emit Time}	_{7.93s (± 0.81%)}	_{7.87s (± 0.30%)}	_{-0.06s (- 0.82%)}	_7.84s	_7.91s	_{p=0.020 n=6}
_{Total Time}	_{22.30s (± 0.44%)}	_{22.17s (± 0.32%)}	_{-0.13s (- 0.58%)}	_22.06s	_22.28s	_{p=0.030 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,400k (± 0.02%)}	_{192,941k (± 0.71%)}	_~	_192,336k	_195,752k	_{p=0.689 n=6}
_{Parse Time}	_{1.56s (± 0.63%)}	_{1.57s (± 1.55%)}	_~	_1.52s	_1.59s	_{p=0.405 n=6}
_{Bind Time}	_{0.82s (± 0.77%)}	_{0.82s (± 0.50%)}	_~	_0.82s	_0.83s	_{p=0.673 n=6}
_{Check Time}	_{10.16s (± 0.63%)}	_{10.14s (± 0.77%)}	_~	_10.02s	_10.25s	_{p=0.468 n=6}
_{Emit Time}	_{2.98s (± 0.45%)}	_{2.99s (± 0.83%)}	_~	_2.96s	_3.03s	_{p=0.560 n=6}
_{Total Time}	_{15.53s (± 0.45%)}	_{15.52s (± 0.41%)}	_~	_15.44s	_15.63s	_{p=0.748 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,127k (± 0.01%)}	_{343,122k (± 0.01%)}	_~	_343,087k	_343,189k	_{p=0.630 n=6}
_{Parse Time}	_{2.80s (± 0.69%)}	_{2.79s (± 0.49%)}	_~	_2.78s	_2.81s	_{p=0.459 n=6}
_{Bind Time}	_{1.08s (± 0.38%)}	_{1.09s (± 1.27%)}	_~	_1.07s	_1.11s	_{p=0.924 n=6}
_{Check Time}	_{7.69s (± 0.46%)}	_{7.70s (± 0.53%)}	_~	_7.63s	_7.74s	_{p=0.628 n=6}
_{Emit Time}	_{4.43s (± 0.62%)}	_{4.43s (± 0.79%)}	_~	_4.40s	_4.47s	_{p=1.000 n=6}
_{Total Time}	_{16.00s (± 0.34%)}	_{16.01s (± 0.45%)}	_~	_15.89s	_16.11s	_{p=0.467 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,238k (± 0.01%)}	_{299,262k (± 0.01%)}	_~	_299,227k	_299,285k	_{p=0.128 n=6}
_{Parse Time}	_{2.17s (± 0.77%)}	_{2.16s (± 0.59%)}	_~	_2.14s	_2.17s	_{p=0.558 n=6}
_{Bind Time}	_{1.24s (± 1.18%)}	_{1.24s (± 1.97%)}	_~	_1.21s	_1.27s	_{p=1.000 n=6}
_{Check Time}	_{7.19s (± 0.43%)}	_{7.18s (± 0.68%)}	_~	_7.11s	_7.24s	_{p=0.936 n=6}
_{Emit Time}	_{4.31s (± 0.23%)}	_{4.35s (± 0.96%)}	_~	_4.28s	_4.41s	_{p=0.063 n=6}
_{Total Time}	_{14.91s (± 0.35%)}	_{14.94s (± 0.53%)}	_~	_14.85s	_15.07s	_{p=0.748 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,736k (± 0.02%)}	_{475,706k (± 0.01%)}	_~	_475,680k	_475,777k	_{p=0.810 n=6}
_{Parse Time}	_{3.28s (± 0.47%)}	_{3.29s (± 0.30%)}	_~	_3.28s	_3.30s	_{p=0.116 n=6}
_{Bind Time}	_{0.97s (± 0.53%)}	_{0.96s (± 0.66%)}	_~	_0.95s	_0.97s	_{p=0.091 n=6}
_{Check Time}	_{18.19s (± 0.85%)}	_{18.10s (± 0.49%)}	_~	_17.98s	_18.23s	_{p=0.470 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.44s (± 0.68%)}	_{22.35s (± 0.40%)}	_~	_22.22s	_22.48s	_{p=0.470 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,579k (± 0.03%)}	_{546,464k (± 0.01%)}	_~	_546,409k	_546,571k	_{p=0.128 n=6}
_{Parse Time}	_{4.26s (± 0.44%)}	_{4.26s (± 0.58%)}	_~	_4.24s	_4.31s	_{p=0.934 n=6}
_{Bind Time}	_{1.76s (± 0.23%)}	_{1.76s (± 0.66%)}	_~	_1.75s	_1.78s	_{p=0.242 n=6}
_{Check Time}	_{2.98s (± 0.46%)}	_{2.99s (± 0.79%)}	_~	_2.96s	_3.02s	_{p=0.683 n=6}
_{Emit Time}	_{0.10s (± 5.34%)}	_{0.09s (± 4.45%)}	_~	_0.09s	_0.10s	_{p=0.112 n=6}
_{Total Time}	_{9.10s (± 0.32%)}	_{9.10s (± 0.48%)}	_~	_9.06s	_9.18s	_{p=0.569 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{352,871k (± 0.00%)}	_{352,873k (± 0.01%)}	_~	_352,848k	_352,907k	_{p=1.000 n=6}
_{Parse Time}	_{3.72s (± 0.50%)}	_{3.71s (± 0.93%)}	_~	_3.66s	_3.76s	_{p=0.294 n=6}
_{Bind Time}	_{1.26s (± 1.79%)}	_{1.25s (± 0.60%)}	_~	_1.24s	_1.26s	_{p=0.734 n=6}
_{Check Time}	_{9.76s (± 0.61%)}	_{9.78s (± 0.39%)}	_~	_9.75s	_9.83s	_{p=0.572 n=6}
_{Emit Time}	_{8.37s (± 0.63%)}	_{8.36s (± 0.91%)}	_~	_8.23s	_8.44s	_{p=1.000 n=6}
_{Total Time}	_{23.11s (± 0.36%)}	_{23.09s (± 0.32%)}	_~	_22.99s	_23.19s	_{p=1.000 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{187,666k (± 0.01%)}	_{187,631k (± 0.02%)}	_~	_187,580k	_187,677k	_{p=0.108 n=6}
_{Parse Time}	_{1.58s (± 0.77%)}	_{1.57s (± 0.26%)}	_~	_1.56s	_1.57s	_{p=0.209 n=6}
_{Bind Time}	_{0.84s (± 0.89%)}	_{0.84s (± 0.75%)}	_~	_0.83s	_0.85s	_{p=0.718 n=6}
_{Check Time}	_{10.21s (± 0.39%)}	_{10.22s (± 0.27%)}	_~	_10.19s	_10.26s	_{p=1.000 n=6}
_{Emit Time}	_{3.14s (± 0.53%)}	_{3.13s (± 1.07%)}	_~	_3.10s	_3.19s	_{p=0.252 n=6}
_{Total Time}	_{15.76s (± 0.26%)}	_{15.76s (± 0.27%)}	_~	_15.71s	_15.82s	_{p=0.806 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{338,153k (± 0.01%)}	_{338,146k (± 0.01%)}	_~	_338,121k	_338,178k	_{p=0.378 n=6}
_{Parse Time}	_{2.88s (± 0.41%)}	_{2.87s (± 0.62%)}	_~	_2.84s	_2.89s	_{p=0.212 n=6}
_{Bind Time}	_{1.10s (± 1.06%)}	_{1.10s (± 0.81%)}	_~	_1.09s	_1.11s	_{p=0.933 n=6}
_{Check Time}	_{8.12s (± 0.31%)}	_{8.09s (± 0.26%)}	_~	_8.06s	_8.11s	_{p=0.075 n=6}
_{Emit Time}	_{4.68s (± 0.86%)}	_{4.68s (± 0.48%)}	_~	_4.66s	_4.71s	_{p=0.466 n=6}
_{Total Time}	_{16.79s (± 0.28%)}	_{16.74s (± 0.21%)}	_~	_16.68s	_16.77s	_{p=0.063 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,298k (± 0.00%)}	_{294,296k (± 0.00%)}	_~	_294,278k	_294,304k	_{p=0.628 n=6}
_{Parse Time}	_{2.40s (± 0.69%)}	_{2.37s (± 0.71%)}	_{-0.02s (- 1.04%)}	_2.35s	_2.39s	_{p=0.036 n=6}
_{Bind Time}	_{1.07s (± 0.38%)}	_{1.06s (± 0.77%)}	_~	_1.06s	_1.08s	_{p=0.109 n=6}
_{Check Time}	_{7.51s (± 0.62%)}	_{7.48s (± 0.35%)}	_~	_7.44s	_7.51s	_{p=0.198 n=6}
_{Emit Time}	_{4.30s (± 0.95%)}	_{4.29s (± 1.22%)}	_~	_4.24s	_4.39s	_{p=0.568 n=6}
_{Total Time}	_{15.27s (± 0.43%)}	_{15.21s (± 0.46%)}	_~	_15.13s	_15.34s	_{p=0.126 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,376k (± 0.01%)}	_{471,399k (± 0.00%)}	_~	_471,356k	_471,422k	_{p=0.230 n=6}
_{Parse Time}	_{3.46s (± 0.24%)}	_{3.44s (± 0.47%)}	_~	_3.42s	_3.46s	_{p=0.198 n=6}
_{Bind Time}	_{1.01s (± 1.70%)}	_{1.00s (± 1.03%)}	_~	_0.99s	_1.02s	_{p=0.410 n=6}
_{Check Time}	_{18.97s (± 0.80%)}	_{18.94s (± 0.57%)}	_~	_18.84s	_19.14s	_{p=0.688 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.44s (± 0.69%)}	_{23.39s (± 0.49%)}	_~	_23.27s	_23.60s	_{p=0.629 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{535,244k (± 0.01%)}	_{535,215k (± 0.01%)}	_~	_535,154k	_535,268k	_{p=0.297 n=6}
_{Parse Time}	_{4.62s (± 0.42%)}	_{4.61s (± 0.38%)}	_~	_4.59s	_4.64s	_{p=0.517 n=6}
_{Bind Time}	_{1.68s (± 0.79%)}	_{1.67s (± 1.00%)}	_~	_1.65s	_1.70s	_{p=0.249 n=6}
_{Check Time}	_{3.18s (± 0.66%)}	_{3.19s (± 0.65%)}	_~	_3.16s	_3.21s	_{p=0.466 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.57s (± 0.44%)}	_{9.56s (± 0.26%)}	_~	_9.53s	_9.60s	_{p=0.748 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₈₄₅	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52845

_Metric	_main	₅₂₈₄₅	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,367ms (± 0.59%)}	_{2,386ms (± 0.58%)}	_~	_2,372ms	_2,410ms	_{p=0.065 n=6}
_{Req 2 - geterr}	_{5,343ms (± 0.73%)}	_{5,376ms (± 0.71%)}	_~	_5,303ms	_5,411ms	_{p=0.173 n=6}
_{Req 3 - references}	_{327ms (± 0.84%)}	_{328ms (± 1.38%)}	_~	_324ms	_335ms	_{p=0.872 n=6}
_{Req 4 - navto}	_{285ms (± 1.03%)}	_{285ms (± 0.66%)}	_~	_282ms	_287ms	_{p=0.808 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 5.12%)}	_{80ms (± 6.61%)}	_~	_74ms	_90ms	_{p=0.789 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,514ms (± 1.30%)}	_{2,525ms (± 0.66%)}	_~	_2,501ms	_2,551ms	_{p=0.336 n=6}
_{Req 2 - geterr}	_{3,999ms (± 0.46%)}	_{4,011ms (± 0.66%)}	_~	_3,979ms	_4,053ms	_{p=0.471 n=6}
_{Req 3 - references}	_{348ms (± 0.93%)}	_{347ms (± 1.12%)}	_~	_342ms	_352ms	_{p=0.467 n=6}
_{Req 4 - navto}	_{294ms (± 0.56%)}	_{293ms (± 0.63%)}	_~	_290ms	_295ms	_{p=0.803 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{72ms (± 4.84%)}	_{75ms (± 1.09%)}	_~	_74ms	_76ms	_{p=0.284 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,183ms (± 0.55%)}	_{3,171ms (± 0.48%)}	_~	_3,153ms	_3,199ms	_{p=0.297 n=6}
_{Req 2 - geterr}	_{1,605ms (± 1.32%)}	_{1,606ms (± 1.10%)}	_~	_1,577ms	_1,627ms	_{p=1.000 n=6}
_{Req 3 - references}	_{105ms (± 2.00%)}	_{104ms (± 1.61%)}	_~	_102ms	_107ms	_{p=0.463 n=6}
_{Req 4 - navto}	_{362ms (± 1.10%)}	_{362ms (± 0.67%)}	_~	_358ms	_364ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{425ms (± 1.91%)}	_{429ms (± 0.67%)}	_~	_425ms	_433ms	_{p=0.630 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,483ms (± 1.85%)}	_{2,475ms (± 1.74%)}	_~	_2,425ms	_2,529ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{5,732ms (± 0.40%)}	_{5,746ms (± 0.54%)}	_~	_5,710ms	_5,779ms	_{p=0.378 n=6}
_{Req 3 - references}	_{342ms (± 0.86%)}	_{344ms (± 0.54%)}	_~	_340ms	_345ms	_{p=0.119 n=6}
_{Req 4 - navto}	_{278ms (± 1.65%)}	_{277ms (± 1.23%)}	_~	_273ms	_281ms	_{p=0.685 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{92ms (± 6.18%)}	_{93ms (± 4.13%)}	_~	_87ms	_97ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,670ms (± 0.68%)}	_{2,677ms (± 0.56%)}	_~	_2,660ms	_2,701ms	_{p=0.377 n=6}
_{Req 2 - geterr}	_{4,380ms (± 0.51%)}	_{4,374ms (± 0.81%)}	_~	_4,325ms	_4,435ms	_{p=0.575 n=6}
_{Req 3 - references}	_{360ms (± 0.78%)}	_{360ms (± 0.67%)}	_~	_356ms	_363ms	_{p=0.871 n=6}
_{Req 4 - navto}	_{291ms (± 0.68%)}	_{289ms (± 0.36%)}	_~	_287ms	_290ms	_{p=0.058 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{74ms (± 3.60%)}	_{73ms (± 2.05%)}	_~	_72ms	_76ms	_{p=0.934 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,357ms (± 0.54%)}	_{3,334ms (± 0.47%)}	_{-23ms (- 0.68%)}	_3,317ms	_3,358ms	_{p=0.037 n=6}
_{Req 2 - geterr}	_{1,742ms (± 0.79%)}	_{1,746ms (± 0.79%)}	_~	_1,729ms	_1,769ms	_{p=0.630 n=6}
_{Req 3 - references}	_{112ms (± 1.63%)}	_{113ms (± 1.17%)}	_~	_112ms	_115ms	_{p=0.383 n=6}
_{Req 4 - navto}	_{349ms (± 1.30%)}	_{348ms (± 0.90%)}	_~	_344ms	_352ms	_{p=0.623 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{435ms (± 0.95%)}	_{435ms (± 0.37%)}	_~	_433ms	_437ms	_{p=0.627 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,570ms (± 0.61%)}	_{2,574ms (± 0.57%)}	_~	_2,558ms	_2,591ms	_{p=0.872 n=6}
_{Req 2 - geterr}	_{6,104ms (± 0.54%)}	_{6,076ms (± 0.34%)}	_~	_6,048ms	_6,104ms	_{p=0.147 n=6}
_{Req 3 - references}	_{356ms (± 0.46%)}	_{359ms (± 0.38%)}	_{+2ms (+ 0.61%)}	_357ms	_361ms	_{p=0.046 n=6}
_{Req 4 - navto}	_{277ms (± 1.08%)}	_{276ms (± 0.27%)}	_~	_275ms	_277ms	_{p=0.741 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{101ms (± 4.24%)}	_{102ms (± 0.40%)}	_~	_101ms	_102ms	_{p=0.445 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,805ms (± 1.03%)}	_{2,816ms (± 0.51%)}	_~	_2,797ms	_2,832ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{4,539ms (± 2.42%)}	_{4,492ms (± 1.90%)}	_~	_4,437ms	_4,662ms	_{p=0.378 n=6}
_{Req 3 - references}	_{378ms (± 4.91%)}	_{388ms (± 6.78%)}	_~	_368ms	_423ms	_{p=0.419 n=6}
_{Req 4 - navto}	_{292ms (± 1.33%)}	_{292ms (± 1.26%)}	_~	_287ms	_295ms	_{p=0.681 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{94ms (±10.27%)}	_{95ms (± 7.87%)}	_~	_86ms	_103ms	_{p=0.746 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,658ms (± 0.17%)}	_{3,649ms (± 0.65%)}	_~	_3,621ms	_3,678ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,849ms (± 0.83%)}	_{1,854ms (± 0.80%)}	_~	_1,838ms	_1,880ms	_{p=0.873 n=6}
_{Req 3 - references}	_{128ms (± 2.17%)}	_{129ms (± 2.54%)}	_~	_124ms	_131ms	_{p=0.933 n=6}
_{Req 4 - navto}	_{376ms (± 1.83%)}	_{373ms (± 0.39%)}	_~	_371ms	_375ms	_{p=0.936 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{458ms (± 3.18%)}	_{447ms (± 2.16%)}	_~	_439ms	_464ms	_{p=0.261 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₈₄₅	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52845

_Metric	_main	₅₂₈₄₅	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.55ms (± 0.26%)}	_{141.06ms (± 0.15%)}	_{-0.49ms (- 0.35%)}	_140.44ms	_143.18ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.90ms (± 0.17%)}	_{225.86ms (± 0.15%)}	_{-1.04ms (- 0.46%)}	_224.96ms	_230.08ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{228.67ms (± 0.16%)}	_{228.05ms (± 0.22%)}	_{-0.61ms (- 0.27%)}	_226.88ms	_235.90ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{209.37ms (± 0.16%)}	_{208.74ms (± 0.16%)}	_{-0.63ms (- 0.30%)}	_207.88ms	_215.26ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₈₄₅	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Jake Bailey (jakebailey)

So, LGTM; these all feel like good changes. But, will need to update DT to reflect the improvement.

Fixed array expression spreads into variadic const calls

4550763

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 18, 2023

Mateusz Burzyński (Andarist) commented Feb 18, 2023

View reviewed changes

Mateusz Burzyński (Andarist) mentioned this pull request Mar 1, 2023

Fixed spreading iterables into arguments list directly into rest-only signatures #52838

Merged

Nathan Shively-Sanders (sandersn) requested review from Jake Bailey (jakebailey) and navya9singh March 7, 2023 19:03

Nathan Shively-Sanders (sandersn) assigned Jake Bailey (jakebailey) Mar 7, 2023

add an extra test case for an invalid call

9a88095

TypeScript Bot (typescript-bot) added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 8, 2023

Jake Bailey (jakebailey) approved these changes Mar 8, 2023

View reviewed changes

Nathan Shively-Sanders (sandersn) mentioned this pull request Mar 8, 2023

Fix inquirer tests for TS 5.1 DefinitelyTyped/DefinitelyTyped#64633

Merged

This was referenced Mar 8, 2023

Update lodash intersectionWith test for new TS improvements DefinitelyTyped/DefinitelyTyped#64635

Merged

Update zen-observable subscribe test for new TS improvements DefinitelyTyped/DefinitelyTyped#64636

Merged

Jake Bailey (jakebailey) merged commit d681520 into microsoft:main Mar 8, 2023

Jake Bailey (jakebailey) mentioned this pull request Jun 28, 2023

got n or more with spread arguments #20372

Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Mateusz Burzyński (Andarist) commented Feb 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 18, 2023

Uh oh!

Mateusz Burzyński (Andarist) Feb 18, 2023

Choose a reason for hiding this comment

Uh oh!

Mateusz Burzyński (Andarist) Feb 18, 2023

Choose a reason for hiding this comment

Uh oh!

Nathan Shively-Sanders (sandersn) commented Mar 7, 2023

Uh oh!

Mateusz Burzyński (Andarist) commented Mar 7, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 8, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023

microsoft/vscode

src/tsconfig.tsec.json

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 8, 2023

Uh oh!

Mateusz Burzyński (Andarist) commented Mar 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Mar 8, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 8, 2023

Compiler

TSServer

Startup

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mateusz Burzyński (Andarist) commented Feb 18, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 8, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 8, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 8, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 8, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 8, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 8, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 8, 2023 •

edited

Loading