Skip to content

Preserve special intersections in mapped types - #50704

Merged
Anders Hejlsberg (ahejlsberg) merged 2 commits into
mainfrom
fix50683
Sep 9, 2022
Merged

Preserve special intersections in mapped types#50704
Anders Hejlsberg (ahejlsberg) merged 2 commits into
mainfrom
fix50683

Conversation

@ahejlsberg

Copy link
Copy Markdown
Member

Fixes #50683.

@ghost ghost self-assigned this Sep 9, 2022
@ghost ghost added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 9, 2022

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast 😄

@ghost
ghost merged commit a70bb9d into main Sep 9, 2022
@ghost
ghost deleted the fix50683 branch September 9, 2022 19:09

ghost commented Sep 9, 2022

Copy link
Copy Markdown
Member

Is this one worth a 4.8 backport? (Might have been fixed if the report had been earlier and included, so...)

@ghost ghost added this to the TypeScript 4.8.4 milestone Sep 12, 2022

ghost commented Sep 12, 2022

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) cherry-pick this to release-4.8

ghost commented Sep 12, 2022

Copy link
Copy Markdown

Heya Andrew Branch (@andrewbranch), I've started to run the task to cherry-pick this into release-4.8 on this PR at 5907d7c. You can monitor the build here.

ghost commented Sep 12, 2022

Copy link
Copy Markdown

Hey Andrew Branch (@andrewbranch), I've opened #50741 for you.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Since 4.8.2, union discrimination fails with (string & {}) when noUncheckedIndexedAccess is true

4 participants