Skip to content

Adding different module resolution strategies - #4352

Merged
Mohamed Hegazy (mhegazy) merged 8 commits into
masterfrom
moduleResolutionStrategies
Aug 24, 2015
Merged

Adding different module resolution strategies#4352
Mohamed Hegazy (mhegazy) merged 8 commits into
masterfrom
moduleResolutionStrategies

Conversation

@vladima

@vladima Vladimir Matveev (vladima) commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

No description provided.

mhegazy
mhegazy reviewed Aug 18, 2015
View reviewed changes
Comment thread src/compiler/program.ts Outdated

@mhegazy Mohamed Hegazy (mhegazy) Aug 18, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we need this since SystemJS allowes it

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Aug 18, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after for

@vladima Vladimir Matveev (vladima) Aug 18, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@vilicvane

vilicvane (vilicvane) commented Aug 19, 2015

Copy link
Copy Markdown

!!! Fantastic, finally got here. Thanks!

yuit
yuit reviewed Aug 19, 2015
View reviewed changes
Comment thread src/compiler/types.ts Outdated

@yuit Yui (yuit) Aug 19, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Legacy? Could you add comment?

@alexeagle

Alex Eagle (alexeagle) commented Aug 20, 2015

Copy link
Copy Markdown
Contributor

+cc Martin Probst (@mprobst)

mhegazy
mhegazy reviewed Aug 20, 2015
View reviewed changes
Comment thread src/harness/harness.ts Outdated

@mhegazy Mohamed Hegazy (mhegazy) Aug 20, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment

@mhegazy

Mohamed Hegazy (mhegazy) commented Aug 20, 2015

Copy link
Copy Markdown
Contributor

👍

Mohamed Hegazy (mhegazy) added a commit that referenced this pull request Aug 24, 2015
@mhegazy
Merge pull request #4352 from Microsoft/moduleResolutionStrategies
9a6db93 
Adding different module resolution strategies
@mhegazy
Mohamed Hegazy (mhegazy) merged commit 9a6db93 into master Aug 24, 2015
@mhegazy
Mohamed Hegazy (mhegazy) deleted the moduleResolutionStrategies branch August 24, 2015 23:03
@mihailik

mihailik commented Aug 25, 2015

Copy link
Copy Markdown
Contributor

Is there a description of what this is doing and how to use it please?

@vilicvane

vilicvane (vilicvane) commented Aug 25, 2015

Copy link
Copy Markdown

mihailik You may specify "moduleResolution" in compilerOptions as "node", then it will try to load declaration file under related node module. For me it seems that either index.d.ts or specified "typings" field in package.json works, not typings related to "main" field.

@mhegazy

Mohamed Hegazy (mhegazy) commented Aug 25, 2015

Copy link
Copy Markdown
Contributor

one thing to add, --m commonjs means your moduleResolution is node, so if this is what you are using, you get the new behavior automatically.

let us know if you run into issues with the new resolution logic.

@jbrantly James Brantly (jbrantly) mentioned this pull request Aug 25, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vladima @vilicvane @alexeagle @mhegazy @mihailik @yuit @DanielRosenwasser @msftclas