Use jsxFragmentFactory entity name for factory name lookup from checking fragments - #39475
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit intoJul 15, 2020
Conversation
Wesley Wigham (weswigham)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Wenlu Wang (Kingwl)
July 7, 2020 21:06
Wesley Wigham (weswigham)
force-pushed
the
jsxfragmentfactory-no-unused
branch
from
July 7, 2020 21:33
947a798 to
a42dd9d
Compare
Wesley Wigham (weswigham)
requested a review
from Nathan Shively-Sanders (sandersn)
July 7, 2020 21:33
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Jul 7, 2020
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Member
There was a problem hiding this comment.
Seems consistent, maybe just get eyes from Ryan Cavanaugh (@RyanCavanaugh) on it though.
Nathan Shively-Sanders (sandersn)
approved these changes
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39451