Remove resolveUntypedCall from checkJsxSelfClosingElementDeferred - #38515
Closed
Nathan Shively-Sanders (sandersn) wants to merge 1 commit into
Closed
Conversation
This doesn't cause any tests to fail; I'll see whether it causes user tests to fail. This call is responsible for a 5% slowdown or so.
Member
Author
|
TypeScript Bot (@typescript-bot) user test this |
Contributor
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized community code test suite on this PR at 4a6f552. You can monitor the build here. |
Nathan Shively-Sanders (sandersn)
assigned
Wesley Wigham (weswigham) and unassigned
Nathan Shively-Sanders (sandersn)
Contributor
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Nathan Shively-Sanders (sandersn)
added
the
Experiment
Member
|
Nathan Shively-Sanders (@sandersn) #40293 supersedes this, includes a test which would have failed with just the removal of the call, and patches the branch of signature resolution that would have failed to error to provide an error so the call is no longer needed (and thus is removed). |
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Jake Bailey (jakebailey)
deleted the
remove-resolveUntypedCall-from-checkJsxSelfClosingElementDeferred
branch
November 7, 2022 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't cause any tests to fail; I'll see whether it causes user tests to fail.
This call is responsible for a 5% slowdown or so in ant-design, which is a generic react library with big types. So it's not too surprising that any additional checking is quite slow.
Fixes, or at least addresses, #38477
From discussion with Wesley Wigham (@weswigham):
Additionally, I'd say: