fix(33511): React Native <Text> component quick fix weird import suggestion - #38419
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoJul 14, 2020
Merged
Conversation
Nathan Shively-Sanders (sandersn)
approved these changes
May 26, 2020
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
The code looks OK, but I don't understand how the old code was broken. Can you explain?
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/33511
branch
from
May 26, 2020 17:40
594c628 to
b63b64f
Compare
Nathan Shively-Sanders (sandersn)
added
the
For Backlog Bug
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/33511
branch
2 times, most recently
from
June 2, 2020 17:57
ac1aa5d to
95b1330
Compare
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/33511
branch
from
July 4, 2020 07:01
95b1330 to
3ad36ca
Compare
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Nathan Shively-Sanders (sandersn)
July 4, 2020 14:35
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/33511
branch
3 times, most recently
from
July 12, 2020 16:53
a669b28 to
f2aade6
Compare
…t exists in the current scope
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/33511
branch
from
July 13, 2020 04:52
f2aade6 to
437588b
Compare
Nathan Shively-Sanders (sandersn)
approved these changes
Jul 14, 2020
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Thanks for bearing with my questions! And sorry I let this sit for so long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33511