Fix four tsc-instrumented bugs - #19314
Merged
Merged
Conversation
Nathan Shively-Sanders (sandersn)
commented
Oct 18, 2017
Nathan Shively-Sanders (sandersn)
commented
Member
- Make recursiveCreateDirectory correctly handle relative paths.
- Remove dependency on Harness
- Correctly increment iocapture0, iocapture1, ... iocaptureN.
- Stop double-nesting baseline files.
1. Make recursiveCreateDirectory correctly handle relative paths. 2. Remove dependency on Harness 3. Correctly increment iocapture0, iocapture1, ... iocaptureN. 4. Stop double-nesting baseline files.
Nathan Shively-Sanders (sandersn)
requested a review
from Wesley Wigham (weswigham)
October 18, 2017 22:31
Mohamed Hegazy (mhegazy)
approved these changes
Oct 18, 2017
Wesley Wigham (weswigham)
approved these changes
Oct 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.