Add exported members of all project files in the global completion list - #13921

Mohamed Hegazy (@mhegazy) Vladimir Matveev (@vladima) comments?

Zhengbo Li (@zhengbli) Does this include files under node_modules aswell?

Yes as long as they have been used in the project at least once

Will the first time import of a class work (this class has not been imported into my source, but the node_modules contains the definition file for this class I'm trying to import)?

No you have to import that module at least once anywhere in your project, so that module becomes part of your project. Otherwise it would be too expensive to search all the folders all the time. The same applies to how we implements the current quick fix now.

Zhengbo Li (@zhengbli) The sheer mention of a dependency in package.json & the presence of the dependency in node_modules implies that the user is wanting to use the module. Most of the time (~99%) user does not modify any file under node_modules manually.

Only npm (or) yarn would trigger a change to the node_modules directory structure, which user would not run very frequently in the project.

So the amount of change cycles that trigger autocomplete index to change are relatively limited from the point of view of the files under node_modules.

Unless I'm missing something, forcing user to import at least once in the project is an arbitrary expectation.

Please let me know if I've missed something

I agree parsing package.json is a good estimate. Though that belongs to a bigger question: whether we should eagerly include modules listed in package.json into the program, which would have impacts on not only completion list, also other features like navigate-to. The changes made in this PR serves as the first step towards and is building based on how the program is currently constructed. That proposed changes to make the program bigger eagerly may go to a separate PR later.

Zhengbo Li (@zhengbli) Is this change going to be part of 2.3?

@thekalinga at this point I'm not sure, depends on if the team has the time to review the changes

Updated with the feature embedded in the "CompletionEntryDetails" API call.

The API looks good to me for VSCode. Looking forward to picking up this change

I'm looking for too for this great feature to integrate it inside Eclipse. Do you know when you think you could merge this issue to master to consume it with typescript@dev ?

Mohamed Hegazy (@mhegazy) do you know when this PR will be accepted? The auto import feature is not in the RoadMap Do you know for which version of TypeScript, it will be available? Thanks!

This is redone in #17851

Merged in #19069. thanks Zhengbo Li (@zhengbli) !