treat ambient non-aliased 'require' as commonjs 'require' - #11819
Merged
Conversation
| return getReturnTypeOfSignature(signature); | ||
| } | ||
|
|
||
| function isCommonJsRequire(node: Node) { |
There was a problem hiding this comment.
May be we need to use this function in completions.ts to determine whether to give module names as completion list?
| return getReturnTypeOfSignature(signature); | ||
| } | ||
|
|
||
| function isCommonJsRequire(node: Node) { |
There was a problem hiding this comment.
May be we need to use this function in completions.ts to determine whether to give module names as completion list?
Sheetal Nandi (sheetalkamat)
requested changes
Oct 24, 2016
Sheetal Nandi (sheetalkamat)
left a comment
Sheetal Nandi (sheetalkamat)
left a comment
Member
There was a problem hiding this comment.
Leave a comment
| return getReturnTypeOfSignature(signature); | ||
| } | ||
|
|
||
| function isCommonJsRequire(node: Node) { |
There was a problem hiding this comment.
May be we need to use this function in completions.ts to determine whether to give module names as completion list?
Contributor
Author
There was a problem hiding this comment.
certainly but it is not related to the original issue so I'd put it into different PR
Mohamed Hegazy (mhegazy)
approved these changes
Oct 24, 2016
Mohamed Hegazy (mhegazy)
left a comment
Mohamed Hegazy (mhegazy)
left a comment
Contributor
There was a problem hiding this comment.
We should make sure completion is also behaving the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11752