This repository was archived by the owner on Jun 10, 2026. It is now read-only.
Optimize multi-index and FTS index insert/update on SQL Providers - #64
Merged
Conversation
Brent Erickson (berickson1)
requested review from
David de Regt (deregtd),
Sergei Dryganets (dryganets) and
Mark Davis (ms-markda)
September 28, 2018 01:13
David de Regt (deregtd)
approved these changes
Sep 28, 2018
We can do the insert and deletes of multi-key indexes in one pass instead of executing multiple queries
Brent Erickson (berickson1)
force-pushed
the
brericks/batchIndex
branch
from
September 28, 2018 18:03
9aae954 to
758f12b
Compare
Mark Davis (ms-markda)
approved these changes
Sep 28, 2018
| // data contains all the input parameters | ||
| for (let i = 0; i < (data.length / insertParamCount); i += itemPageSize) { | ||
| const thisPageCount = Math.min(itemPageSize, (data.length / insertParamCount)) - i; | ||
| const qmarksValues = _.fill(new Array(thisPageCount), generateParamPlaceholder(insertParamCount)); |
There was a problem hiding this comment.
Suggestion: The same _.repeat idea could be used here instead of _.fill, Array, and .join.
_.repeat('(' + generateParamPlaceholder(insertParamCount) + '),', thisPageCount).slice(0, -1);Perhaps this could be extracted:
repeatWithSeparator(str: string, n: number, sep: string) {
return _.repeat(str + sep, n).slice(0, -sep.length);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can do the insert and deletes of multi-key indexes in one pass instead of executing multiple queries