Canary pipeline fixes - #224
Merged
Merged
Conversation
Tom Care (tcare)
commented
Mar 9, 2020
Tom Care (tcare)
commented
Contributor
- Use the variable template so we don't have to manually define MODEL_NAME and MODEL_VERSION
- Upgrade helm version to 3.1.1 to fix some issues
- Enable ACR authentication using service principals rather than a manual secret
- Upgrade helm version to 3.1.1 - Remove ACR secret from the abtest-model deployment
Tom Care (tcare)
requested review from
David Tesar (dtzar),
Eugene Fedorenko (eedorenko) and
jotaylo
March 9, 2020 22:22
jotaylo
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.