Skip to content

Doc linklint fixups#894

Merged
bpkroth merged 4 commits into
microsoft:mainfrom
bpkroth:more-docs
Dec 7, 2024
Merged

Doc linklint fixups#894
bpkroth merged 4 commits into
microsoft:mainfrom
bpkroth:more-docs

Conversation

@bpkroth

@bpkroth bpkroth commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Pull Request

Title

Doc linklint fixups


Description

GithubPages serves our docs out of a /MLOS path, but previously we checked things out of / using an Nginx docker container.

This PR changes the Nginx docker container used for testing to also serve paths out of /MLOS and fixes the broken links found from that.


Type of Change

  • 📝 Documentation update

Testing

  • Existing CI (which includes docstring and some link lint checks)

@bpkroth bpkroth added the WIP Work in progress - do not merge yet label Dec 6, 2024
@bpkroth bpkroth changed the title yet another link error More docstring updates Dec 6, 2024
Comment thread doc/source/index.rst
@bpkroth bpkroth changed the title More docstring updates Doc linklint fixups Dec 6, 2024
@bpkroth bpkroth added ready for review Ready for review and removed WIP Work in progress - do not merge yet labels Dec 6, 2024
@bpkroth bpkroth marked this pull request as ready for review December 6, 2024 23:10
@bpkroth bpkroth requested a review from a team as a code owner December 6, 2024 23:10
Comment thread doc/nginx-default.conf
Comment thread doc/nginx-default.conf
@bpkroth bpkroth enabled auto-merge (squash) December 6, 2024 23:12

@motus motus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bpkroth bpkroth merged commit 3faaa56 into microsoft:main Dec 7, 2024
@bpkroth bpkroth deleted the more-docs branch December 7, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants