Skip to content

Include strtobool from older version of python#866

Merged
bpkroth merged 4 commits into
microsoft:mainfrom
bpkroth:strtobool-compat
Oct 3, 2024
Merged

Include strtobool from older version of python#866
bpkroth merged 4 commits into
microsoft:mainfrom
bpkroth:strtobool-compat

Conversation

@bpkroth

@bpkroth bpkroth commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

Pull Request

Title

Include strtobool from a now deprecated version of python.


Description


Type of Change

  • 🛠️ Bug fix

@bpkroth bpkroth requested a review from a team as a code owner October 3, 2024 20:17
@bpkroth bpkroth enabled auto-merge (squash) October 3, 2024 20:18
@bpkroth

bpkroth commented Oct 3, 2024

Copy link
Copy Markdown
Contributor Author

@eujing

@motus motus disabled auto-merge October 3, 2024 21:54

@motus motus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - with one tiny nitpick

Comment thread mlos_bench/mlos_bench/util.py Outdated
Co-authored-by: Sergiy Matusevych <sergiy.matusevych@gmail.com>
@bpkroth bpkroth enabled auto-merge (squash) October 3, 2024 22:00
@bpkroth bpkroth merged commit df8eac0 into microsoft:main Oct 3, 2024
@bpkroth bpkroth deleted the strtobool-compat branch October 3, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

distutils deprecation with Python 12 preventing mlos_bench from launching

2 participants