Skip to content

Migrate to ConfigSpace 1.*#802

Merged
motus merged 35 commits into
microsoft:mainfrom
motus:sergiym/opt/configspace-1.0
Aug 2, 2024
Merged

Migrate to ConfigSpace 1.*#802
motus merged 35 commits into
microsoft:mainfrom
motus:sergiym/opt/configspace-1.0

Conversation

@motus

@motus motus commented Jul 17, 2024

Copy link
Copy Markdown
Member

Summary of changes:

  • Update dependencies to ConfigSpace >= 1.0.
  • Update dependencies to SMAC3 >= 2.2.
  • Migrate to new ConfigSpace API.
  • Better definition of ConfigSpace fixture in unit tests.
  • Fix mypy and pylint issues triggered by the migration.

Notes:

Closes #727

@motus motus added dependencies Pull requests that update a dependency file WIP Work in progress - do not merge yet mlos-core mlos-bench labels Jul 17, 2024
@motus motus self-assigned this Jul 17, 2024
Comment thread mlos_core/setup.py
Comment thread mlos_core/setup.py
Comment thread mlos_bench/mlos_bench/optimizers/convert_configspace.py
@bpkroth

bpkroth commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

That ConfigSpace update to SMAC was merged, but they haven't cut a new version for us to pull in yet.

@motus motus marked this pull request as ready for review July 25, 2024 02:14
@motus motus requested a review from a team as a code owner July 25, 2024 02:14
@motus motus removed the WIP Work in progress - do not merge yet label Jul 25, 2024
Comment thread mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_test.py
Comment thread mlos_core/mlos_core/optimizers/bayesian_optimizers/smac_optimizer.py Outdated
Comment thread mlos_core/mlos_core/optimizers/flaml_optimizer.py Outdated
Comment thread mlos_core/mlos_core/spaces/adapters/llamatune.py Outdated
Comment thread mlos_core/mlos_core/spaces/adapters/llamatune.py Outdated
Comment thread mlos_core/mlos_core/spaces/adapters/llamatune.py Outdated
Comment thread mlos_core/mlos_core/optimizers/flaml_optimizer.py
Comment thread mlos_core/setup.py Outdated
Comment thread setup.cfg

@bpkroth bpkroth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just would like to get that quantization support back in asap.

Main remaining question is around the param.to_vector(param.to_vector(...)) transformation. Didn't quite look right, but maybe I'm missing something?

@motus

motus commented Jul 31, 2024

Copy link
Copy Markdown
Member Author

unit tests seem to break because of #826 - checking it now

@motus motus force-pushed the sergiym/opt/configspace-1.0 branch from cc67ece to 96ad677 Compare July 31, 2024 23:41
Comment thread conda-envs/mlos-windows.yml Outdated
@bpkroth bpkroth mentioned this pull request Aug 1, 2024
bpkroth added a commit that referenced this pull request Aug 1, 2024
Splitting out from #802 to benefit other jobs as well.
@motus motus merged commit a5f36a8 into microsoft:main Aug 2, 2024
@motus motus deleted the sergiym/opt/configspace-1.0 branch August 2, 2024 23:37
motus added a commit that referenced this pull request Aug 6, 2024
This PR enables Python 3.12 in Windows environment and does not restrict
Python version in the default environments on Windows and Linux. Note
that although `mlos-3.12.yml` exists, its usage is still commented out
in `linux.yml`, because Python 3.12 is still not available on GitHub CI.
Issue #832 opened to track it

P.S. Also, we now use a lighter `matplotlib-base` instead of
`matplotlib` proper

~To be merged after #802~

---------

Co-authored-by: Brian Kroth <bpkroth@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file mlos-bench mlos-core ready for review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConfigSpace crashes with Python 3.12

2 participants