bugfix: is_defaults() is a method, not property#782
Merged
Conversation
motus
added
bug
bpkroth
approved these changes
Jul 10, 2024
bpkroth
left a comment
bpkroth
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Would be nice to have some way to sanity check this for the future, but it's probably overkill. Maybe something that looks at the values and sees if they're callable and issues a warning or something like that.
DelphianCalamity
pushed a commit
to DelphianCalamity/MLOS
that referenced
this pull request
Jul 12, 2024
Closes microsoft#781 Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
bpkroth
added a commit
that referenced
this pull request
Jul 24, 2024
Test for #782 Makes `new_trial` a wrapper with a sanity check and renames the previous `new_trial` abstractmethod to `_new_trial`. --------- Co-authored-by: Sergiy Matusevych <sergiym@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #781