Skip to content

Better naming and values for MockEnv parameters + unit tests#769

Merged
bpkroth merged 14 commits into
microsoft:mainfrom
motus:sergiym/env/mock_env_seed
Jul 2, 2024
Merged

Better naming and values for MockEnv parameters + unit tests#769
bpkroth merged 14 commits into
microsoft:mainfrom
motus:sergiym/env/mock_env_seed

Conversation

@motus

@motus motus commented Jun 28, 2024

Copy link
Copy Markdown
Member
  • Use mock_env_range, mock_env_seed, and mock_env_metrics instead of just range, seed, and metrics to avoid naming conflicts.
  • Use integer mocl_env_seed values to distinguish between deterministic behavior, random seed, and user-specified seed for MockEnv.
  • Update unit tests and configs to validate the seed behavior.
  • Add new unit tests for different initializations of the tunable values

@motus motus self-assigned this Jun 28, 2024
@motus motus requested a review from a team as a code owner June 28, 2024 23:46
@motus motus mentioned this pull request Jun 28, 2024
Merged
bpkroth
bpkroth reviewed Jul 1, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/tests/config/tunable-values/tunable-values-example.jsonc
bpkroth
bpkroth reviewed Jul 1, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/tests/config/cli/mock-bench.jsonc
bpkroth
bpkroth reviewed Jul 2, 2024
View reviewed changes
Comment thread mlos_bench/mlos_bench/tests/config/tunable-values/tunable-values-example.jsonc
@bpkroth bpkroth enabled auto-merge (squash) July 2, 2024 20:36
@bpkroth bpkroth merged commit 6bf3862 into microsoft:main Jul 2, 2024
bpkroth added a commit that referenced this pull request Jul 3, 2024
@motus @bpkroth
Make sure One Shot Optimizer always returns the same suggestion (#759)
62d7efb 
Make sure the `OneShotOptimizer.suggest()` call always returns the same
configuration.

Changes related to `MockEnv` determinism moved to #769 

Closes #755

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@motus motus deleted the sergiym/env/mock_env_seed branch August 1, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bpkroth bpkroth bpkroth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@motus motus

Labels

mlos-bench ready for review Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@motus @bpkroth