Introduce pyproject.toml build changes by bpkroth · Pull Request #764 · microsoft/MLOS

bpkroth · 2024-06-28T17:13:22Z

This PR builds off of #762 and #763

These are in part

followup fixups for Cascading series of CI dependency problems #746 (e.g., to allow setuptools-scm to be pulled in at build time as a build dependency only when conda an pip have mismatched version issues), and
Modernization improvements to allow us to make better use of other tools (e.g., black that only accept pyproject.toml files as their configuration files).

To do so, we move some configs from setup.py to pyproject.toml for each module.
However, to retain the ability to rewrite URLs in published README.md files on PyPi as well as consistent version dependencies across modules without the need to manually specify version numbers (e.g., using setuptools-scm) we mark a few dependencies as dynamic and leave our existing logic inside the setup.py file.

Finally, we reorganize the version.py file to be inside the module and fix a few previous omissions for mlos_viz.

…ve changed since the last successful build. This should help improve incremental rebuilds in dev loops.

…project-toml-build-changes

bpkroth · 2024-07-02T21:23:01Z

@motus I'm thinking we cut a new release after this and the OneShotOptimizer fixups are in.

Builds off of #762, #763, and #764. Prepares rules and configs to enable isort and black formatters and checks but doesn't enable them yet. After these are enabled (next PR) we will reformat all files and ignore that revision in git blame configs. Then, we can convert configs stored in `setup.cfg` and `.pylintrc` to the top level `pyproject.toml` and remove the older configs.

bpkroth added 14 commits June 28, 2024 16:09

start introducing format target

bd19a92

new global vars to help reuse elsewhere

a1fc746

clean format targets on conda rebuild

2af7971

rework some dependencies in some rules

d6d2e9b

rework pytest rules for simplicity

77d3982

Rename a clean target for consistency

89a2907

introduce clean-format target

fdf400b

fixup message

7a2e645

Adjust the Makefile check rules to only rerun checks on files that ha…

b890eae

…ve changed since the last successful build. This should help improve incremental rebuilds in dev loops.

Introduce pyproject.toml and new build mechanisms, refactor version.py

e7880fb

Revert back to prefering default conda repo instead of conda forge

287fb4f

This directive was moved to pyproject.toml files

4dd6b5b

Omit the notebooks from the sdist and whl files

3a7ab0c

include a toml extension in vscode

2777483

bpkroth mentioned this pull request Jun 28, 2024

Prepare isort black formatters and checks #766

Merged

bpkroth added 3 commits June 28, 2024 17:39

comment

148ca57

not ready for that one yet

7ca2026

CI trigger

ebdd526

bpkroth force-pushed the pyproject-toml-build-changes branch from 9e5e239 to ebdd526 Compare June 28, 2024 17:58

bpkroth added 2 commits June 28, 2024 20:33

CI trigger

e77f585

CI trigger

04a674a

bpkroth mentioned this pull request Jun 28, 2024

Change formatter to black to strongly enforce pep8 style #744

Closed

bpkroth added 3 commits July 1, 2024 16:00

Merge branch 'main' into makefile-improvements-with-incremental-support

8ae75ec

Merge branch 'makefile-improvements-with-incremental-support' into py…

d68383b

…project-toml-build-changes

Leave those changes stagged in another PR for now

2a74dbc