Skip to content

Allow multiple objectives in the optimizer config#725

Merged
bpkroth merged 33 commits into
microsoft:mainfrom
motus:sergiym/opt/multiobjective_config
Apr 30, 2024
Merged

Allow multiple objectives in the optimizer config#725
bpkroth merged 33 commits into
microsoft:mainfrom
motus:sergiym/opt/multiobjective_config

Conversation

@motus

@motus motus commented Mar 26, 2024

Copy link
Copy Markdown
Member
  • Update JSON schema to use "optimizer_target": {"score": "min"} format
  • Update base Optimizer class to use the new config format (throw NotImplementedError if > 1 target)
  • Modify all unit tests to use the new format

Part of #692

Merge after #723

motus added 24 commits March 22, 2024 14:55
@motus motus requested a review from a team as a code owner March 26, 2024 23:57
@motus motus self-assigned this Mar 27, 2024
@motus motus changed the title Allow multiple objectives in optimizer config Allow multiple objectives in the optimizer config Mar 28, 2024
Comment thread mlos_bench/mlos_bench/config/schemas/cli/common-defs-subschemas.json Outdated
Comment thread mlos_bench/mlos_bench/config/schemas/optimizers/optimizer-schema.json Outdated
Comment thread mlos_bench/mlos_bench/config/experiments/README.md Outdated
Comment thread mlos_bench/mlos_bench/optimizers/base_optimizer.py Outdated

@bpkroth bpkroth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a slight naming change, otherwise LGTM

@bpkroth bpkroth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bpkroth bpkroth enabled auto-merge (squash) April 29, 2024 23:05
@bpkroth bpkroth merged commit fbdc116 into microsoft:main Apr 30, 2024
@motus motus deleted the sergiym/opt/multiobjective_config branch May 1, 2024 00:21
motus added a commit that referenced this pull request May 9, 2024
* [x] Store multiple optimization targets and directions in base
`Optimizer` class
* [x] Support multiple optimization targets in mock and grid search
optimizers
* [x] Check for single objective in `MlosCoreOptimizer` class (will add
support for multiple objectives after implementing that feature in
`mlos_core` in subsequent PRs)
* [x] Update unit tests in mlos_bench

Merge after ~#723~ and ~#725~

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants